1212600 - No upper limit on digest256 list file size

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Matt Wobensmith [:mwobensmith][:matt:]]

Some error/boundary tests revealed that Firefox accepted and parsed an 88mb list file. We don't anticipate ever supporting a list file that big, and in fact would like to limit the list size to something more reasonable, such as 32mb. 

As per discussion with François, we'd probably want to reject this condition at download time, parse time, or both.

Comment 1

[Matt Wobensmith [:mwobensmith][:matt:]]

See also bug 1212601.

Comment 2

[Dimi Lee [:dimi]]

Attachment: MozReview Request: Bug 1212600 - No upper limit on digest256 list file size. r=francois

Review commit: https://reviewboard.mozilla.org/r/42765/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42765/

Comment 3

[François Marier [:francois]]

Comment on attachment 8735383 [details]
MozReview Request: Bug 1212600 - No upper limit on digest256 list file size. r=francois

https://reviewboard.mozilla.org/r/42765/#review39233

Comment 4

[François Marier [:francois]]

Comment on attachment 8735383 [details]
MozReview Request: Bug 1212600 - No upper limit on digest256 list file size. r=francois

gcp, does that look reasonable to you too?

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8735383 [details]
MozReview Request: Bug 1212600 - No upper limit on digest256 list file size. r=francois

https://reviewboard.mozilla.org/r/42765/#review39479

Looks fine, but we should consider gathering these limits together. (i.e. this + MAX_CHUNK_SIZE, MAX_CHUNK_RANGE, etc)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7c857bd36bc2

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7c857bd36bc2