Closed
Bug 1213163
Opened 9 years ago
Closed 9 years ago
Validation fails with "Sub-package must be signed" for single-package XPIs with a jar inside.
Categories
(addons.mozilla.org Graveyard :: Add-on Validation, defect)
addons.mozilla.org Graveyard
Add-on Validation
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ma1, Unassigned)
References
Details
I was unable to upload a new NoScript RC in the beta channel, had to explode the jar inside chrome/, modify chrome.manifest and repackage. It looks like the validator consider the jar as it was a nested XPI.
Comment 1•9 years ago
|
||
:mstriemer it seems this "inner jar" thing was an issue after all ;)
Flags: needinfo?(mstriemer)
Comment 2•9 years ago
|
||
Yes, many add-ons have internal JARs. If this is blocking developers from submitting, we should back that out ASAP.
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/amo-validator https://github.com/mozilla/amo-validator/commit/a3ce9a714e1d186d14c140b2e0a54a0b472d9cba Don't require signed inner JAR when not multipackage (bug 1213163) Require all inner XPI files to be signed but not JAR files. Fixes #331
Comment 4•9 years ago
|
||
This is now on prod and should work fine for NoScript, sorry about that.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(mstriemer)
Resolution: --- → FIXED
Comment 5•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/amo-validator https://github.com/mozilla/amo-validator/commit/a3ce9a714e1d186d14c140b2e0a54a0b472d9cba Don't require signed inner JAR when not multipackage (bug 1213163)
Comment 6•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/amo-validator https://github.com/mozilla/amo-validator/commit/a3ce9a714e1d186d14c140b2e0a54a0b472d9cba Don't require signed inner JAR when not multipackage (bug 1213163)
Comment 7•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/amo-validator https://github.com/mozilla/amo-validator/commit/a3ce9a714e1d186d14c140b2e0a54a0b472d9cba Don't require signed inner JAR when not multipackage (bug 1213163)
Assignee | ||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•