Closed
Bug 1213465
Opened 9 years ago
Closed 9 years ago
Combine DrawResults correctly in nsTablePainter
Categories
(Core :: Layout: Images, Video, and HTML Frames, defect)
Core
Layout: Images, Video, and HTML Frames
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: seth, Assigned: seth)
References
Details
Attachments
(1 file)
7.15 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
We're not correctly combining DrawResults in nsTablePainter. We need to prefer other failing DrawResults over BAD_IMAGE, as discussed in bug 1209715 and implemented for the DrawResult |operator&| overloads, but nsTablePainter is still using its own DrawResult combining code that doesn't do that. We can fix this by using the operator overloads.
Assignee | ||
Comment 1•9 years ago
|
||
This actually simplifies the code! We don't need the local UpdateDrawResult() function at all anymore.
Attachment #8672145 -
Flags: review?(tnikkel)
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=91fe811422dd
Updated•9 years ago
|
Attachment #8672145 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Thanks for the review!
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/88c55feebfc4
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/88c55feebfc4
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•