1213587 - The XML error page has a yellow background but does not specify foreground color

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Pim Blokland]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 SeaMonkey/2.38
Build ID: 20150923193515

Steps to reproduce:

1) in Options, Content, Fonts & Colors, Colors (or in SeaMonkey: Preferences, Appearance, Colors), change the foreground color to white and the background color to white. Also uncheck the "Use system colors" checkbox.

2) load a badly formatted XHTML file, or type this into the location bar:
data:text/xml,%3C


Actual results:

The error page that appears has the user's chosen foreground color for the text (white) but it has a light yellow background, which makes the text unreadable.


Expected results:

The error page should either
- have black hardcoded for a foreground color (or something that contrasts with light yellow)
- or respect both foreground and background from the user's preferences, in this case white on black.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Add foreground color to the background color for XML error pages

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c5c82835f0c&group_state=expanded

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fbe817b7d36517de4033753e63b53d2260c16b8e
Bug 1213587 - Add foreground color to the background color for XML error pages.  r=xidorn

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fbe817b7d365