1214533 - Move History and Cookie button down in Browsing Privacy panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Attachment: History and Cokie

As spec https://mozilla.app.box.com/s/axgrq6v7uousbd4274swqss6mi8pd2vi/1/4257534077/35064879857/1 shown in bug 1207717

Move History and Cokie section down in Browsing Privacy panel

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1214533-move-history-and-cookie-in-privacy > mozilla-b2g:master

Comment 2

[Scott Wu [:scottwu]]

Comment on attachment 8674721 [details] [review]
[gaia] scottwu:1214533-move-history-and-cookie-in-privacy > mozilla-b2g:master

Moved the buttons and also refactored to use dialog service. Added a few more integration tests.

Please take a look and let me know if any change is necessary. Thank Fred :)

Comment 3

[[e-mail]]

Comment on attachment 8674721 [details] [review]
[gaia] scottwu:1214533-move-history-and-cookie-in-privacy > mozilla-b2g:master

Overall looks good! But please test with reset-gaia to make sure all production config is correct.

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8674721 [details] [review]
[gaia] scottwu:1214533-move-history-and-cookie-in-privacy > mozilla-b2g:master

I've excluded the dialog_service module in require.js config, but I found that not excluding it still worked on my device. Results from Treeherder didn't find errors either.

Comment 6

[[e-mail]]

Comment on attachment 8674721 [details] [review]
[gaia] scottwu:1214533-move-history-and-cookie-in-privacy > mozilla-b2g:master

Looks great! thanks scott.

Comment 7

[Scott Wu [:scottwu]]

Thanks Fred!