1214573 - [Windows] Saved Passwords import option is not displayed when importing from IE

Status: RESOLVED WORKSFORME

(Firefox :: Migration, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Reproducible on:Firefox 44.0a1, Firefox 43.0a2 and Firefox 42 beta 6 under Windows

Prerequisites: Internet Explorer is installed and has:
- browsing history
- saved passwords

STR
1.Run Firefox and go to about:preferences#security
2.Click on "Saved Passwords" button
3.Click on "Import" button.
4.Select Internet Explorer from the "Import Settings and Data" window and then press "Next"
5.Check the “Item to Import” list.


ER
Saved Passwords option is mentioned in “Item to Import” list.

AR
Saved Passwords option does not appear in “Item to Import” despite the fact that the passwords are successfully imported (except Bug 1191175).
See screenshot: http://i.imgur.com/qeBLsvu.jpg


Additional notes:
- This issue is reproducible on Firefox 44.0a1 (2015-10-13), Firefox 43.0a2 (2015-10-13) and Firefox 42 Beta 6 (20151012151721) under Windows 8 32-bit and only on Firefox 42 Beta 6 using Windows 7 64-bit.
- This issue is not reproducible on Windows 10 64-bit.
- Saved password option does not appear also for first time run import wizard or when importing from "Show all bookmarks"

Comment 1

[:Gijs (he/him)]

This is expected on 42, but not on 43+. The IE passwords on windows 7 and below are imported using bug 682069 and that did not get uplifted to 42.

Comment 2

[:Gijs (he/him)]

Gah, bugzilla...

Comment 3

[:Gijs (he/him)]

On win8, did you actually have any saved passwords for IE?

Comment 4

[:Gijs (he/him)]

After saving a password in IE on win8, I cannot reproduce on 44.

Comment 5

[Vasilica Tamas, QA [:vtamas]]

I think import password from IE works in Firefox 42 because of Bug 1192035

Saved passwords are successfully imported from IE in Firefox 44.0a1 (2015-10-14), Firefox 43.0a2 (2015-10-14) and Firefox 42 beta 6 using Windows 8 64-bit. This happens if “Keep me logged in” checkbox is checked for each website in Internet Explorer. 

Otherwise (if “Keep me logged in” checkbox is not checked) the saved passwords are not imported.

Noticed today, that “Saved password” option appears in latest Nightly and latest Aurora. So, this bug seems to be intermittently for Firefox 44.0a1 and Firefox 43.0a2.

Comment 6

[:Gijs (he/him)]

(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #5)
> I think import password from IE works in Firefox 42 because of Bug 1192035
> 
> Saved passwords are successfully imported from IE in Firefox 44.0a1
> (2015-10-14), Firefox 43.0a2 (2015-10-14) and Firefox 42 beta 6 using
> Windows 8 64-bit. This happens if “Keep me logged in” checkbox is checked
> for each website in Internet Explorer. 
> 
> Otherwise (if “Keep me logged in” checkbox is not checked) the saved
> passwords are not imported.

This doesn't make sense. Passwords are imported only if you save them to the IE password store. That's done via the popup or notification bar that IE uses to prompt if you want to save a password. It has nothing to do with the "keep me logged in" checkbox on a website (which will remember your login cookie, but won't make the saved passwords be imported into Firefox).


> Noticed today, that “Saved password” option appears in latest Nightly and
> latest Aurora. So, this bug seems to be intermittently for Firefox 44.0a1
> and Firefox 43.0a2.

This also doesn't make sense to me. Also, in this post you're saying it's working in Windows 8 64-bit, but comment #0 uses Windows 8 32-bit. Did you test on different machines? Is the result consistently different? It's possible that I broke something in bug 1207106, but that would affect 44 and not 43 because that patch wasn't uplifted.

Comment 7

[Vasilica Tamas, QA [:vtamas]]

(In reply to :Gijs Kruitbosch from comment #6)

> Did you test on different machines? Is the result consistently different? 

I've test on the same machine but on different operating systems. This time I've checked on both windows, the Saved Password option appeared for all Firefox versions, including Firefox 42. I don't know how is this possible.


This is what I have noticed: 

“Keep me logged in” checkbox not checked and "Would you like to store your password?" - "YES" navigating to yahoo.com, I’ve been already signed in - the password, username, last used and last changed details are displayed in about:preferences#security

“Keep me logged in” checkbox checked and "Would you like to store your password?" - "NO" :navigating to yahoo.com, I’ve been already signed in - no password displayed in about:preferences#security, only site, username, last used and last changed details appeared in Saved Password window.

Tested on Firefox 42 beta 6 on Windows 8 64-bit and Windows 8 32-bit.

Comment 8

[:Gijs (he/him)]

(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #7)
> (In reply to :Gijs Kruitbosch from comment #6)
> 
> > Did you test on different machines? Is the result consistently different? 
> 
> I've test on the same machine but on different operating systems. This time
> I've checked on both windows, the Saved Password option appeared for all
> Firefox versions, including Firefox 42. I don't know how is this possible.
> 
> 
> This is what I have noticed: 
> 
> “Keep me logged in” checkbox not checked and "Would you like to store your
> password?" - "YES" navigating to yahoo.com, I’ve been already signed in -
> the password, username, last used and last changed details are displayed in
> about:preferences#security
> 
> “Keep me logged in” checkbox checked and "Would you like to store your
> password?" - "NO" :navigating to yahoo.com, I’ve been already signed in - no
> password displayed in about:preferences#security, only site, username, last
> used and last changed details appeared in Saved Password window.
> 
> Tested on Firefox 42 beta 6 on Windows 8 64-bit and Windows 8 32-bit.

OK, then it sounds like this is working as expected.