1214992 - [Stingray][Home] Filter should also search cards inside folders

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

When we switch filters, the cards inside folders doesn't appears anywhere else besides "all" filter. By the latest ux spec, we need to put out those cards too - as one line (e.g. omit the folder structure when filtering)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] rexboy7:1214992-filter-folder-cards > mozilla-b2g:master

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8674047 [details] [review]
[gaia] rexboy7:1214992-filter-folder-cards > mozilla-b2g:master

Hi Yifan:

This feature is written in spec but not included in 2.5. Would you mind review it? Since it's not a blocker you can do it when you are available.

Comment 3

[yifan [:yifan][:yliao]]

Comment on attachment 8674047 [details] [review]
[gaia] rexboy7:1214992-filter-folder-cards > mozilla-b2g:master

Thanks!

Comment 4

[yifan [:yifan][:yliao]]

Comment on attachment 8674047 [details] [review]
[gaia] rexboy7:1214992-filter-folder-cards > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: The behavior is not aligned to UX spec.
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=96a1f9bcf70ba4855c62d4b030a7b18f664274d3
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master
https://github.com/mozilla-b2g/gaia/commit/d446a25f2c020b7f671e4e1ec5a46aa37653d694

Comment 6

[Mahendra Potharaju [:mahe]]

Comment on attachment 8674047 [details] [review]
[gaia] rexboy7:1214992-filter-folder-cards > mozilla-b2g:master

Approved for 2.5 uplift.
Thanks

Comment 7

[Carsten Book [:Tomcat]]

landed on 2.5 https://github.com/mozilla-b2g/gaia/commit/760e531734791ed187ffe33c8a9ac1550784e61b