1215450 - Treeherder single result set view is stuck "waiting for a push with revision xxx"

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Oleg Zasypkin [:azasypkin]]

Please, see [1], Treeherder doesn't show any results and just always displays "waiting for a push with revision xxx", it happens for other PR pushes as well. Close-open PR didn't help.

At the same time, [2] works fine.

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=49beb2be50cc62ca7f687d27dd95840e26528e47

[2] https://treeherder.mozilla.org/#/jobs?repo=gaia

Comment 1

[Oleg Zasypkin [:azasypkin]]

Hey Kendall,

We were advised that you can help to diagnose this :)

Thanks!

Comment 2

[Kendall Libby [:fubar] (he/him)]

weird. I don't actually know what's up there. NI on Cam, maybe he knows what's up?  (sadly, he's PST, and Ed's out today)

Comment 3

[Cameron Dawson [:camd]]

I see what's going on here.  I think a recent change caused a regression here.  Working on a fix now.  I'll try to get it pushed out as soon as possible.  But may only make it to stage today, tbh.

Comment 4

[Cameron Dawson [:camd]]

This will happen with any revision that is full 40 chars in github repos.  The full 40 has been stored, but we are only searching for the 12 char, so it can never find it.  We need to search for both short and long in that field.

Comment 5

[Cameron Dawson [:camd]]

As a sort-of work around, you can change the URL param from "revision" to "tochange" which will show your revision at the top of the list.

Comment 6

[Cameron Dawson [:camd]]

Attachment: PR

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c080e5aa64fbfc4e34c92e5412c0ecf8ff34da3e
Bug 1215450 - single resultset view stuck when using long revision

Some repos have been storing 40 char revisions, though most only store
12.
But a recent change to search by only 12 chars, even if 40 passed in
broke
the ability to search when the stored length was 40.  This change will
search for both length revisions, if the 40 char is passed in.

Comment 8

[Cameron Dawson [:camd]]

this is now fixed and pushed to master.  It should go to stage and production servers soon.