Closed
Bug 1215519
Opened 9 years ago
Closed 9 years ago
We shouldn't ship RTCCertificate.expires as a Date
Categories
(Core :: WebRTC: Signaling, defect, P1)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla44
backlog | webrtc/webaudio+ |
People
(Reporter: bzbarsky, Assigned: mt)
References
Details
Attachments
(1 file, 1 obsolete file)
4.46 KB,
patch
|
mt
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]: Last chance to avoid shipping an API we don't want to ship. See https://github.com/w3c/webrtc-pc/issues/324 and https://www.w3.org/Bugs/Public/show_bug.cgi?id=22824 for details. We haven't shipped this on the web yet, so this is our chance to not make that mistake.... Given this is in 42, it's our last chance, though, right? We should just return a long long instead, I think.
Flags: needinfo?(martin.thomson)
Assignee | ||
Comment 1•9 years ago
|
||
Spec change requested: https://github.com/w3c/webrtc-pc/pull/342
Assignee | ||
Comment 2•9 years ago
|
||
WDYT?
Flags: needinfo?(martin.thomson)
Attachment #8675188 -
Flags: review?(bzbarsky)
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8675188 [details] [diff] [review] 0001-Bug-1215519-Switch-to-DOMTimeStamp-for-RTCCertificat.patch r=me
Attachment #8675188 -
Flags: review?(bzbarsky) → review+
Updated•9 years ago
|
backlog: --- → webrtc/webaudio+
Rank: 15
Priority: -- → P1
Comment 4•9 years ago
|
||
Tracking as it is the last moment (beta 9 gtb is tomorrow) to get that. Bz, Martin, could you fill the uplift request? Thanks
Assignee: nobody → martin.thomson
status-firefox42:
--- → affected
status-firefox43:
--- → affected
Flags: needinfo?(martin.thomson)
Flags: needinfo?(bzbarsky)
Keywords: checkin-needed
Assignee | ||
Comment 5•9 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: 1215519 [User impact if declined]: none, but releasing a feature we don't want makes it very hard to remove later [Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76d7051252ac [Risks and why]: there are some users who might be relying on this being a Date; I can probably personally talk to them though [String/UUID change made/needed]: none
Attachment #8675188 -
Attachment is obsolete: true
Flags: needinfo?(martin.thomson)
Flags: needinfo?(bzbarsky)
Attachment #8676971 -
Flags: review+
Attachment #8676971 -
Flags: approval-mozilla-beta?
Attachment #8676971 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
Comment on attachment 8676971 [details] [diff] [review] bug1215519v2.patch Now is the time (or never), should be in 42 beta 9.
Attachment #8676971 -
Flags: approval-mozilla-beta?
Attachment #8676971 -
Flags: approval-mozilla-beta+
Attachment #8676971 -
Flags: approval-mozilla-aurora?
Attachment #8676971 -
Flags: approval-mozilla-aurora+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7dc8fdb76c6a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/4018d92c9f2a but it has problems to apply to beta: merging dom/media/PeerConnection.js merging dom/media/webrtc/RTCCertificate.h warning: conflicts during merge. merging dom/media/webrtc/RTCCertificate.h incomplete! (edit conflicts, then use 'hg resolve --mark') could you take a look ?
Flags: needinfo?(martin.thomson)
Updated•9 years ago
|
Assignee | ||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/e91b6fcbc1bb Only trivial changes required.
You need to log in
before you can comment on or make changes to this bug.
Description
•