Closed
Bug 1215673
Opened 9 years ago
Closed 9 years ago
Imagecompare RTL: wait until the screen transition is complete
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: njpark, Assigned: njpark)
Details
Attachments
(1 file)
In certain cases, tests fail because the screenshot is taken while the screen is still transitioning. http://jenkins1.qa.scl3.mozilla.com/view/Graphics/job/flame-kk-512.mozilla-central.nightly.ui.graphics.RTL/ws/screenshots/mismatches/test_settings_app_valid_login_findmydevice-password_flame_ar_2+2015-10-16-13-19-27_diff.png
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → npark
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Basically, I was waiting before the beginning of methods, but the waiting should be at the end of the methods, because otherwise take_screeshot() can't take reliable shots.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8675150 -
Flags: review?(martijn.martijn)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8675150 [details] [review] [gaia] npark-mozilla:1215673 > mozilla-b2g:master Looks fine to me. The only thing I wonder about is the many Wait element present/displayed calls. I would think often in those instances, you could just use find_element there.
Attachment #8675150 -
Flags: review?(martijn.martijn) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Merged: https://github.com/mozilla-b2g/gaia/commit/c12c598f55616c0dd17380d508a08c0a1a4af6ab
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•