1215698 - Changing system wide font size makes history item titles disappear

Status: VERIFIED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Stephan Leroux [:sleroux]]

STR:

1. Open History panel with some populated history items
2. Background the app and navigate to Settings -> Accessibility -> Larger Text and increase or decrease the text size
3. Switch back to the app

Expected:

Cell titles still be visible

Actual:

Cell titles become hidden

------

Eventually we'll want to use dynamic type and have the size increase but for now the titles should appear.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: IMG_4713.PNG

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I am moving this to 2.0+ because it is an edge case.

The text disappears when you go "Settings -> Accessibility -> Larger Text" and change the size.

But if you switch back and forth between bookmarks and history, history will correctly reload.

This is annoying and I would like to understand why this is happening and correctly deal with it, but I don't think we should block on it now.

We would block on it if we would render that list badly with non-default text size settings. But that is not the case.

Comment 3

[Richard Newman [:rnewman]]

We have a 1.2 flag now, so let's put this there until we figure out scope.

Comment 4

[Aaron Train [:aaronmt]]

Out of curiosity is iPad affected?

Comment 5

[Stephan Leroux [:sleroux]]

:AaronMT - Yup it happens on iPad as well.

Comment 6

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1194

Seems like modifying the UITableViewCell's default label fonts doesn't work well with dynamic type. UITableViewCell makes assumptions on how to handle it's labels and what font it should and by us change the font it breaks and causes the labels to disappear. I've replaced the default labels with custom ones but overrode the accessors to allow external consumers to remain unchanged. When we want to add support for dynamic type, we should refactor our cell code to use custom label types and listen for dynamic type size notifications to handle the text updates.

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8678960 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1194

LGTM

Comment 8

[Stephan Leroux [:sleroux]]

Merged

Comment 9

[Catalin Suciu [:csuciu]]

Verifying as fixed on Beta 1.2 (1201)