1215724 - Brotli doesn't work over SPDY

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[piotrsikora]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.101 Safari/537.36

Steps to reproduce:

Connect to a server (localhost, sorry) running nginx-1.9.4 (with SPDY/3.1) with ngx_brotli module.


Actual results:

Firefox didn't send "accept-encoding" header (even though it's displayed in Developer Tools). It was fine to skip it when only gzip was supported, since SPDY spec requires clients to support it, but now that Brotli is also supported, Firefox needs to send it.


Expected results:

Firefox should send "accept-encoding: gzip, deflate, br" header.

Comment 1

[Patrick McManus [:mcmanus]]

I guess so - for the most part spdy is waiting to die and we don't add new features to it.. but in this case the feature shouldn't be transport version specific.

thanks for noticing.

Comment 2

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe1f6a46a5d9

Comment 3

[Patrick McManus [:mcmanus]]

Attachment: enable brotli on spdy

Comment 4

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c23714f8078b2fe7665438daa6217867490568b1
bug 1215724 - enable brotli on spdy r=hurley

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c23714f8078b

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c23714f8078b