1215756 - TEST-UNEXPECTED-FAIL | test_mozprocess_poll.ProcTestPoll.test_poll_while_running | AssertionError: Detected process is not running, process output: []

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Edmund Wong (:ewong)]

Getting this on SeaMonkey Linux32 comm-central build's make check:

TEST-UNEXPECTED-FAIL | test_mozprocess_poll.ProcTestPoll.test_poll_while_running | AssertionError: Detected process is not running, process output: []
Traceback (most recent call last):
  File "/builds/slave/c-cen-t-lnx/build/mozilla/testing/mozbase/mozprocess/tests/test_mozprocess_poll.py", line 42, in test_poll_while_running
    True)
  File "/builds/slave/c-cen-t-lnx/build/mozilla/testing/mozbase/mozprocess/tests/proctest.py", line 64, in determine_status
    self.assertTrue(detected, "Detected process is not running, process output: %s" % output)
TEST-INFO took 7ms

Comment 1

[Andrew Halberstadt [:ahal]]

This actually happens in Firefox in automation too, but due to bug 1139911 it wasn't turning the builds orange.

Also test_mozprocess_wait.ProcTestWait.test_waittimeout has the same error:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2df0cf0235c

I'll take a quick look.. if the solution isn't trivial, I vote we disable them for now so we can land bug 1139911 ASAP.

Comment 2

[Julien Pagès (:parkouss)]

Ok, did a quick fix, seems to work locally, so pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c91ee19e3759

That should probably be fixed in a better way - using the process id instead of parsing the command line of all processes to see if a process is running :( But this involve a bigger change (not much, but still) and anyway it was like this before we broke the tests.

Original issue comes from my patch in bug 1139487.

Comment 3

[Julien Pagès (:parkouss)]

Attachment: MozReview Request: Bug 1215756 - TEST-UNEXPECTED-FAIL | test_mozprocess_poll.ProcTestPoll.test_poll_while_running | AssertionError: Detected process is not running, process output: []. r=ahal

Bug 1215756 - TEST-UNEXPECTED-FAIL | test_mozprocess_poll.ProcTestPoll.test_poll_while_running | AssertionError: Detected process is not running, process output: []. r=ahal

Comment 4

[Julien Pagès (:parkouss)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=32d8a57c0654

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8676382 [details]
MozReview Request: Bug 1215756 - TEST-UNEXPECTED-FAIL | test_mozprocess_poll.ProcTestPoll.test_poll_while_running | AssertionError: Detected process is not running, process output: []. r=ahal

https://reviewboard.mozilla.org/r/22685/#review20147

Thanks for investigating, lgtm!

Comment 6

[Julien Pagès (:parkouss)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=354e5272b836

Comment 7

[Julien Pagès (:parkouss)]

Attachment: 1215756.patch

So, previous patch was not working for mac. Here is an improved version, which now check processes in a better and secure way.

Can't push that to try until the end of the day (CEST), feel free to do so if you want to.

Comment 8

[Andrew Halberstadt [:ahal]]

Comment on attachment 8676673 [details] [diff] [review]
1215756.patch

Review of attachment 8676673 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, nice cleanup! r+ assuming it works.. I'll push it to try.

::: testing/mozbase/mozprocess/tests/proctest.py
@@ +25,5 @@
> +        returncode = proc.proc.returncode
> +        didtimeout = proc.didTimeout
> +        detected = psutil.pid_exists(proc.pid)
> +        output = ''
> +        # ProcessHandler have output when store_output is set to True in the constructor

s/have/has

Comment 9

[Andrew Halberstadt [:ahal]]

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c75da30a8275

Comment 10

[Julien Pagès (:parkouss)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c68fa4bb22f5

Comment 11

[Julien Pagès (:parkouss)]

Attachment: fixed the nits

Ok, fixed the nit. (this was the patch on the last try).

Comment 12

[Julien Pagès (:parkouss)]

So, green on try. try is closed, so asking for checkin-needed.

Thanks!

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72bf30ffd771

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72bf30ffd771