1215807 - Crash when processing "after junk" filter on POP account with maildir (Debug build only)

Status: NEW

(MailNews Core :: Filters, defect)

Description

[Jorg K (CEST = GMT+2)]

Crash when processing "after junk" rules on POP account with maildir.

What else do I need to say?

STR:
Create a POP account using maildir storage.
Create a rule that runs after junk clasification
  (I used: move to folder HUHU if subject contains HUHU).
Send an e-mail to this account with HUHU in the subject.
Download e-mail and crash!

For details see bug 1211261 comment #32.

Comment 1

[Jorg K (CEST = GMT+2)]

Is this the regression from bug 1152651 you were looking for? I tried on mbox, that works.

Comment 2

[Kent James (:rkent)]

The crash you mention is an assertion per bug 1211261 comment #32  That means this is behavior that will not crash in a release build, but is not supposed to happen, so we don't allow it in debug builds.

You've essentially though found STR of a condition that has been a problem. OnEndExecution should not be called twice, and if it is we should trace out the cause and fix it.

Comment 3

[Jorg K (CEST = GMT+2)]

Kent, thanks for looking at it.

The STR can be simplified so you don't have to send and receive a message every time.

Original:
Create a POP account using maildir storage.
Create a filter that runs after junk clasification
  (I used: move to folder HUHU if subject contains HUHU).
Send an e-mail to this account with HUHU in the subject.
Download e-mail and crash!

Simpler:
Configure the filter to run only manually.
Then send the message, and receive it. It will go to the inbox (and can be used for repeating the test).
Now run the manual filter.

Result:
Assertion failure: mNeedsRelease (OnEndExecution called a second time), at c:/mozilla-source/comm-central/mailnews/base/search/src/nsMsgFilterService.cpp:364
#01: nsMsgFilterAfterTheFact::RunNextFilter (c:\mozilla-source\comm-central\mailnews\base\search\src\nsmsgfilterservice.cpp:418)
#02: nsMsgFilterAfterTheFact::ApplyFilter (c:\mozilla-source\comm-central\mailnews\base\search\src\nsmsgfilterservice.cpp:891)
#03: nsMsgFilterAfterTheFact::OnStopCopy (c:\mozilla-source\comm-central\mailnews\base\search\src\nsmsgfilterservice.cpp:1152)
#04: nsMsgMaildirStore::CopyMessages (c:\mozilla-source\comm-central\mailnews\local\src\nsmsgmaildirstore.cpp:1121)
#05: nsMsgLocalMailFolder::CopyMessages (c:\mozilla-source\comm-central\mailnews\local\src\nslocalmailfolder.cpp:1574)
#06: nsMsgCopyService::DoNextCopy (c:\mozilla-source\comm-central\mailnews\base\src\nsmsgcopyservice.cpp:320)
#07: nsMsgCopyService::DoCopy (c:\mozilla-source\comm-central\mailnews\base\src\nsmsgcopyservice.cpp:261)

Comment 4

[:aceman]

Can you please retry the crash with the new filter logging enabled?

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to :aceman from comment #4)

Can you please retry the crash with the new filter logging enabled?

Alex,

IIRC you are using maildir. Can you reproduce using comment 0 and capture the filter log?

Comment 6

[Alex ARNAUD]

(In reply to Wayne Mery (:wsmwk) from comment #5)

(In reply to :aceman from comment #4)

Can you please retry the crash with the new filter logging enabled?

Alex,

IIRC you are using maildir. Can you reproduce using comment 0 and capture the filter log?

I'm really sorry Wayne, I no longer use maildir.