1215951 - [pl] make default width of pageInfo dialog a tad wider

Status: RESOLVED FIXED

(Mozilla Localizations :: pl / Polish, defect)

Description

[Axel Hecht [:Pike]]

Looking at http://pike.github.io/firefox-l10n-tests/?file=security%2Fdv-details.png&locale=pl, the pageinfo dialog should get a tad wider default width.

The width of that dialog is persisted, so you need to test on a new window. My suspicion is that 620 is OK.

Way to test: Open firefox with a new profile, enable remote debugging, use window.resizeBy(20,0) to verify, switch through all tabs to confirm.

Yeah, that's pretty naughty, and it took me a while to find this for another locale. Which looked similarily cut off and 620 was OK there.

Comment 1

[Stefan Plewako [:stef]]

I don't see it on OS X 10.11 and 42 beta but I do on 44 nightly.
Deleting xulstore.json from profile seems to remove remembered window size.

Could anyone test this under Windows 10 (and optionally 7) for 42 and 44 and tell me how much resizing is needed there?

Comment 2

[Stefan Plewako [:stef]]

https://hg.mozilla.org/l10n-central/pl/rev/2dcd35d5baf0
https://hg.mozilla.org/releases/l10n/mozilla-aurora/pl/rev/838948745f51
https://hg.mozilla.org/releases/l10n/mozilla-beta/pl/rev/68d4bc0d416d

Comment 3

[Stefan Plewako [:stef]]

https://hg.mozilla.org/l10n-central/pl/rev/b8830093a4c6

Comment 4

[Stefan Plewako [:stef]]

Attachment: 1215951.png

Firefox 42, https://www.google.pl, TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, pageInfoWindow.width set to 600 px

Comment 5

[Stefan Plewako [:stef]]

On Windows 7 even 640 px is not enough to have shortened pageInfo_Privacy_Encrypted2 fit into two lines.

https://hg.mozilla.org/l10n-central/pl/rev/6410f42a6d8b sets window size to 650x500 making pageInfo_Privacy_Encrypted2 two lines, making all fit (tested on Windows 7, OS X 10.11) and giving us few pixels in reserve (both dimensions).

Comment 6

[Stefan Plewako [:stef]]

Minimal window width seems to be related to cipher used and https://www.google.pl for example has one with longer name (TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256) than tested on http://pike.github.io/firefox-l10n-tests/?file=security%2Fdv-details.png&locale=de pushing things right and making situation even worse.

Would it be possible to use site with longer/longest cipher name in firefox-l10n-tests?

Comment 7

[Stefan Plewako [:stef]]

https://hg.mozilla.org/l10n-central/pl/rev/6410f42a6d8b
https://hg.mozilla.org/releases/l10n/mozilla-aurora/pl/rev/6410f42a6d8b
https://hg.mozilla.org/releases/l10n/mozilla-beta/pl/rev/be9d6188c917

Comment 8

[Stefan Plewako [:stef]]

Looks good to me on Windows 7 and OS X El Capitan.

Comment 9

[Axel Hecht [:Pike]]

(In reply to Stefan Plewako [:stef] from comment #6)
> Minimal window width seems to be related to cipher used and
> https://www.google.pl for example has one with longer name
> (TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256) than tested on
> http://pike.github.io/firefox-l10n-tests/?file=security%2Fdv-details.
> png&locale=de pushing things right and making situation even worse.
> 
> Would it be possible to use site with longer/longest cipher name in
> firefox-l10n-tests?

I'm building on top of Henrik's suite, forwarding the question to him. Do you know?

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

If you need another page for l10n testing you can make the modifications in your own test. We cannot change it for the base firefox-ui-tests given that we do not want to use remote websites. mozqa.com is located in scl3 and we can access internally without using a proxy. I don't know about the security stuff but maybe we could setup another subdomain with a longer cipher.

Comment 11

[Stefan Plewako [:stef]]

Just had an opportunity to test this on Windows 10 and it is even worse… :(
At the size that was good for Windows 7, in 10 the window is not high enough and help button was cut.

https://hg.mozilla.org/l10n-central/pl/rev/8a5c37228e6b