1216254 - "TypeError: _structuredFormatter[message.action] is not a function" when running some mochitests under the debugger

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[(no longer active)]

STR:

$ ./mach mochitest dom/workers/test/serviceworkers/test_fetch_event.html --debugger=lldb
...
TEST-UNEXPECTED-FAIL | /tests/dom/workers/test/serviceworkers/test_fetch_event.html | uncaught exception | TypeError: _structuredFormatter[message.action] is not a function at http://mochi.test:8888/tests/SimpleTest/TestRunner.js:229 - expected: PASS
JavaScript error: http://mochi.test:8888/tests/SimpleTest/TestRunner.js, line 229: TypeError: _structuredFormatter[message.action] is not a function

Comment 1

[(no longer active)]

RyanVM focuses only on Firefox desktop.

chmanchester, perhaps you know what broke this?  This is going to make it difficult to debug various tests (ironically including the mochitests for Firefox desktop!)

Comment 2

[Chris Manchester (limited bugmail, email directly)]

This is fallout from bug 1042998. The formatter used when a debugger is present doesn't implement the "buffering_on" and "buffering_off" actions.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1216254 - [mochitest] Ignore unknown log actions when interactive debugger enabled, r=chmanchester

Bug 1216254 - [mochitest] Ignore unknown log actions when interactive debugger enabled, r=chmanchester

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8675905 [details]
MozReview Request: Bug 1216254 - [mochitest] Ignore unknown log actions when interactive debugger enabled, r=chmanchester

https://reviewboard.mozilla.org/r/22493/#review20053

Comment 5

[Andrew Halberstadt [:ahal]]

Here's a nominal try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=08fc944cfddc

I also tested locally with --debugger=gdb and confirmed the fix. Sorry about that.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/debc5269aeac

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/debc5269aeac