Closed
Bug 1216322
Opened 9 years ago
Closed 9 years ago
change webactivity code for add-ons to be more specific than "install"
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P1)
Tracking
(blocking-b2g:2.5+, feature-b2g:2.5+)
VERIFIED
FIXED
People
(Reporter: ddurst, Assigned: mikehenrty)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
The [+] button to get more add-ons in Gaia that relies on web activities should be more specific than "install" (https://github.com/mozilla-b2g/gaia/blob/c7df972bf6ac24769cc2f74a80c48dfaedcdb040/apps/settings/js/panels/addons/panel.js#L19-L22, https://github.com/fxos/directory/blob/9c6e805b37bb0af3973ad9b3538515070f7b06fe/app/manifest.webapp#L31-L37). Can we use "marketplace-category" and slug "addons"? Marking as P1 due to time and the fact that we're hoping to coordinate and land this this week.
|
||
Updated•9 years ago
|
feature-b2g: --- → 2.5+
|
||
Comment 1•9 years ago
|
||
Marketplace is now expecting "marketplace-category" with "addons" slug. This is implemented in a similar fashion elsewhere in gaia for homescreens and langpacks, FWIW.
|
||
Updated•9 years ago
|
QA Whiteboard: [COM=Add-on]
Michael, could you take a look into this please?
Flags: needinfo?(mhenretty)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → mhenretty
blocking-b2g: --- → 2.5+
Component: Gaia → Gaia::Settings
Flags: needinfo?(mhenretty)
Whiteboard: [systemsfe]
|
||
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8677454 [details] [review] [gaia] mikehenrty:bug-1216322-addon-activity > mozilla-b2g:master David, does this work for you? Yura, can you do the review?
Attachment #8677454 -
Flags: review?(yzenevich)
Attachment #8677454 -
Flags: feedback?(ddurst)
|
Reporter | |
Comment 5•9 years ago
|
||
Comment on attachment 8677454 [details] [review] [gaia] mikehenrty:bug-1216322-addon-activity > mozilla-b2g:master Indeed. Thank you!
Attachment #8677454 -
Flags: feedback?(ddurst) → feedback+
|
|
Reporter | |
Comment 6•9 years ago
|
||
(never used that feedback control before, apologies if I boogered it)
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8677454 [details] [review] [gaia] mikehenrty:bug-1216322-addon-activity > mozilla-b2g:master Thanks
Attachment #8677454 -
Flags: review?(yzenevich) → review+
|
|
Assignee | |
Comment 8•9 years ago
|
||
Thanks all! master: https://github.com/mozilla-b2g/gaia/commit/cb3360b9a0348a1f0d020793292932c803259908
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 9•9 years ago
|
||
verified and fixed with Aries build ID 20151029010303
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•