121663 - NSS3.4 / crash on importing p12 file

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Kai Engert (:KaiE:)]

I used a fresh profile and imported a p12 file. After having entered the file
password, it crashes.

0  0x43d04976 in PORT_FreeArena (arena=0xdadadada, zero=0) at secport.c:270
#1  0x43cb931f in DestroyDBEntry (entry=0x8ad4420) at pcertdb.c:1241
#2  0x43cbc828 in AddCertToPermDB (handle=0x8685970, cert=0x8b31400,
nickname=0x8ad44f0 'Ú' <repeats 200 times>..., trust=0xbfffc7c4) at pcertdb.c:3126
#3  0x43cbdc14 in nsslowcert_AddPermCert (dbhandle=0x8685970, cert=0x8b31400,
nickname=0x8892bd8 "Kai Engert's America Online Inc ID", trust=0xbfffc7c4) at
pcertdb.c:4026
#4  0x43cc32c2 in pk11_handleCertObject (session=0x8a8ac98, object=0x849d480) at
pkcs11.c:604
#5  0x43cc508d in pk11_handleObject (object=0x849d480, session=0x8a8ac98) at
pkcs11.c:1430
#6  0x43cc7e4e in NSC_CreateObject (hSession=16777224, pTemplate=0xbfffc894,
ulCount=10, phObject=0xbfffc918) at pkcs11.c:2948
#7  0x43c41ad0 in PK11_ImportCert (slot=0x8863860, cert=0x8af4590,
key=2664007238, nickname=0x8b3dbd8 "Kai Engert's America Online Inc ID",
includeTrust=1) at pk11cert.c:1575
#8  0x43c437ef in PK11_ImportCertForKeyToSlot (slot=0x8863860, cert=0x8af4590,
nickname=0x8b3dbd8 "Kai Engert's America Online Inc ID", addCertUsage=1,
wincx=0x0) at pk11cert.c:2723
#9  0x43bd7aca in sec_pkcs12_add_cert (cert=0x8bbc7a8, keyExists=1, wincx=0x0)
at p12d.c:2400
#10 0x43bd895e in sec_pkcs12_install_bags (safeBags=0x8addfe8, wincx=0x0) at
p12d.c:2850
#11 0x43bd8b46 in SEC_PKCS12DecoderImportBags (p12dcx=0x8b7e3c0) at p12d.c:2906
#12 0x43b6335c in nsPKCS12Blob::ImportFromFile (this=0xbfffca74, file=0x8b77d30)
at ../../../../../mozilla/security/manager/ssl/src/nsPKCS12Blob.cpp:182

Comment 1

[Kai Engert (:KaiE:)]

adding dependency

Comment 2

[Kai Engert (:KaiE:)]

It only crashes with some p12 files. The file which crashes contains a dual-key
cert as issued by the Netscape internal CA. I'm able to import a p12 file, as I
described it in bug 121487.

Comment 3

[Stephane Saux]

I can replicate the bug on Win2k, stack trace is the same.

Comment 4

[Robert Relyea]

I checked in a fix before lunch time, when did you pull the tree. (it's the same
stack trace as the generating new keys).

bob

Comment 5

[Stephane Saux]

was it pcertdb.c ? I'm rebuilding now.

Comment 6

[Kai Engert (:KaiE:)]

The crash is fixed for me. Marking fixed. Stephane, please reopen if you still
crash.

Comment 7

[John Unruh]

Verified on Linux and Win2000 1/28 NSS3.4 builds.