1216679 - Remove conversation window orange indicators for tab and video sharing

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect, P2)

Description

[Ed Lee :Mardak]

From bug 1214215 comment 4, we want to remove the orange tab sharing and video sharing indicators from the conversation window.

An initial look points to changing browser code outside of browser/components/loop

Not strictly dependent on bug 1214215.

Comment 1

[Mark Banner (:standard8)]

We need more detailed consideration of this.

Firstly we should probably have some folks consider any privacy aspects.

Secondly the existing global controls for "control sharing" currently redirect to the pop-up that is underneath the orange icons, so we would need something to replace that.

I'm not against removing them, but I think its a little more complicated than just hiding thr buttons.

Comment 2

[Pau Masiá [:Pau]]

Ok, right now we have two buttons that perform the same action (or at it least they should). From one side, we have this little orange indicator on the top bar of the conversation window and, on the other side, we have the camera/microphone controls. With the camera and microphone controls in the conversation window, users should be able to turn on/off their camera and microphone so no other button/icon should be needed to control that. What I'm saying is that the best we could do is to remove that orange indicator and replace its functionality by the camera/microphone controls that were specially thought for that. No need to have duplicates.

Comment 3

[Mark Banner (:standard8)]

That's true and reasonable, but it doesn't address what happens with the global controls for finding the window/tab that's sharing the camera/microphone.

Comment 4

[Pau Masiá [:Pau]]

I don't thinks that's an issue since we're planning to have that blue toolbar always present. To me, it makes no sense keeping that orange indicators. Plus, if we are worried about where to place the browser permissions button, it should be placed on the left side of the URL bar. Taking into account how these indicators behave right now (specially the video permissions one), I definitely think we should get rid of them asap.

Comment 5

[Mark Banner (:standard8)]

(In reply to Pau Masiá [:Pau] from comment #4)
> I don't thinks that's an issue since we're planning to have that blue
> toolbar always present. To me, it makes no sense keeping that orange
> indicators. Plus, if we are worried about where to place the browser
> permissions button, it should be placed on the left side of the URL bar.

To me, that could confuse the user into thinking that the site has gained access when it is only Hello using it.

Adam: Do you know who's likely to be able to advise us on the privacy aspects of potentially removing these icons from the conversation window toolbar and the global toolbar just for built-in Hello?

Comment 6

[Adam Roach [:abr]]

(In reply to Mark Banner (:standard8) from comment #5)
> Adam: Do you know who's likely to be able to advise us on the privacy
> aspects of potentially removing these icons from the conversation window
> toolbar and the global toolbar just for built-in Hello?

Given that this is a clear security issue, I think that would be Richard Barnes.

I'll offer my two cents: this conversation is confusing the permissions controls with the stream controls. Mute/unmute is a very different set of operations than grant permission/revoke permission. The user needs to be able to do both. Actually, strike that: the user MUST be able to control permissions. Mute is more of a "pretty important nice-to-have."

Finally, I'll mention that the platform team is presently working on a way to switch devices, and I'm pretty sure it's going to hang off the permissions icon. So, even if the proposal in this bug passes security muster -- and I don't think it will -- you'll be a sad panda if you remove this control, since leaving it in will get you device control in Hello for free.

Comment 8

[Richard Barnes [:rbarnes]]

I'm a little unclear on precisely what is being proposed here.  It would be helpful if someone could post a screenshot of the current UI and an explanation of the changes from that?

As a general rule, anything that makes it less clear what is being shared would be a negative.  Likewise, anything that is different for Hello from the normal UX is likely to lead to confusion.

Comment 9

[Ed Lee :Mardak]

Attachment: current design

Comment 10

[Ed Lee :Mardak]

Attachment: proposed design

This bug was filed to track the work to match the proposed design, which does not have the orange video/tab sharing indicators. I'm not sure if they were explicitly removed or accidentally not included.

Comment 11

[Ed Lee :Mardak]

I grabbed the screenshot of the proposed design from http://people.mozilla.org/~sfranks/Hello/Firefox%20Hello%20Link%20Generator.png

Comment 12

[Sevaan Franks [:sevaan]]

The controls were accidentally not included, but I'm not sure this window is the place for these controls anyway. The conversation window is going away eventually when we move to a sidebar, so the placement of those controls will need reevaluating anyway. Is it not clear enough to show the icons next to the control center icon in the URL Bar?

NIing Phlsa here as I believe he has looked into this before.

Comment 13

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Sevaan Franks [:sevaan] from comment #12)
> Is it not clear enough to show the icons next
> to the control center icon in the URL Bar?

Those indicate that the site has access to the camera (which isn't the case here – Hello is using it).

I don't think there's much value in keeping the indicators in the Hello window (other than perhaps the opportunity to switch devices when that lands). The security risk is much lower, since Hello is part of Firefox. As for the global indicators that just switch to the tab, Hello provides its own mute/close/camera mute controls which make more sense in that context.

Comment 14

[Mark Banner (:standard8)]

Ok, I've summarised the discussion in the user story to put together a list of requirements that I think apply to the current UX and should apply to the next iteration of the UX.

If there's any you think are wrong/incorrect, please highlight.

If we can get a UX design that we think meets those requirements, then I think we could bring people together to discuss and confirm before we move forward with the implementation.

Comment 15

[Ian Bicking (:ianbicking)]

The functionality and description of the icons reminds me very much of Checkboxes that Kill: http://limi.net/checkboxes-that-kill/

Comment 16

[Pau Masiá [:Pau]]

I couldn't agree more, Ian.

Comment 17

[Mark Banner (:standard8)]

I don't think we have to keep the indicators/drop-downs in their current form, that's not what I'm suggesting.

I think we need to come up with something that meets the requirements (or is close to) and doesn't allow the user to mess up their experience.

Comment 19

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.