1217117 - Getting performance data can still be rather slow

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

It turns out that by instead of filtering on the signature hash, instead of the signature id, we have to consider millions of performance datum elements which we don't need to (because we can no longer use the signature id index to filter). Fixing this is easy and gives a substantial performance boost (going from 12 seconds on one query to less than 1): 

mysql> show profiles;
+----------+-------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Query_ID | Duration    | Query                                                                                                                                                                                                                                                                                                        |
+----------+-------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|        1 | 11.28814050 | SELECT `performance_signature`.`signature_hash`, `performance_datum`.`job_id`, `performance_datum`.`result_set_id`, `performance_datum`.`push_timestamp`, `performance_datum`.`value` FROM `performance_datum` INNER JOIN `performance_signature` ON ( `performance_datum`.`signature_id` = `performance_sig |
|        2 |  0.00409075 | SELECT `performance_signature`.`signature_hash`, `performance_datum`.`job_id`, `performance_datum`.`result_set_id`, `performance_datum`.`push_timestamp`, `performance_datum`.`value` FROM `performance_datum` INNER JOIN `performance_signature` ON ( `performance_datum`.`signature_id` = `performance_sig |
+----------+-------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
2 rows in set, 1 warning (0.10 sec)

Comment 1

[William Lachance (:wlach)]

Attachment: PR

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8677021 [details] [review]
PR

Looks good :-)
r=me presuming Travis goes green - it's still running after 17 mins :-/

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/05f377ab929221c1a35f56794f8e6bb93efcba5f
Bug 1217117 - Further optimize getting performance datums