1217377 - (Gaia RTL 2.5) CSS refactoring: Callscreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[pelloux]

This bug is for the CSS refactoring of the Callscreen app, following the new BiDi guidelines.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1217377-callscreen-rtl-css > mozilla-b2g:master

Comment 5

[pelloux]

Comment on attachment 8680034 [details] [review]
[gaia] Phoxygen:bug1217377-callscreen-rtl-css > mozilla-b2g:master

Hi Gabriele,
Could you review this PR please?

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8680034 [details] [review]
[gaia] Phoxygen:bug1217377-callscreen-rtl-css > mozilla-b2g:master

Looks good to me, thanks!

Comment 7

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/51879e8e6d8ac18dc2d8c455f11918fab3fc1111

Comment 8

[Augustin Trancart [:autra]]

Comment on attachment 8680034 [details] [review]
[gaia] Phoxygen:bug1217377-callscreen-rtl-css > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): None
[User impact] if declined: Bad rtl experience for callscreen
[Testing completed]: on flame
[Risk to taking this patch] (and alternatives if risky): medium because the patch is big. There is no alternative to support RTL for the callscreen.
[String changes made]: none.

Comment 9

[Augustin Trancart [:autra]]

Comment on attachment 8680034 [details] [review]
[gaia] Phoxygen:bug1217377-callscreen-rtl-css > mozilla-b2g:master

Clearing uplift as it is already in 2.5

Comment 10

[William Hsu [:whsu]]

(In reply to Augustin Trancart [:autra] from comment #9)
> Comment on attachment 8680034 [details] [review]
> [gaia] Phoxygen:bug1217377-callscreen-rtl-css > mozilla-b2g:master
> 
> Clearing uplift as it is already in 2.5

I saw the commits on github history (Commits on Oct 28, 2015), but the patch doesn't work.
The action buttons on the dialer screen are at the same location.
Please refer to the bug 1217755.