Closed Bug 1217565 Opened 9 years ago Closed 9 years ago

Fix widget assertion to take bug 1213567 into account

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file)

Patch
1.17 KB, patch
jimm
: review+
lizzard
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
This needs to be fixed before 43 goes to beta.
Attached patch Patch — — Splinter Review 

        Attachment #8677656 -
        Flags: review?(jmathies)

    
  

        Attachment #8677656 -
        Flags: review?(jmathies) → review+

    
    

    
  
Comment on attachment 8677656 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1213567
[User impact if declined]: assertions when 43 goes to beta with asyncInit
[Describe test coverage new/current, TreeHerder]: plugin test suite
[Risks and why]: None, updates a sanity check
[String/UUID change made/needed]: None

        Attachment #8677656 -
        Flags: approval-mozilla-aurora?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d26c5883da8e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox44:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

    
    

    
  
Comment on attachment 8677656 [details] [diff] [review]
Patch

OK to uplift, good that this gets caught before 43 goes to beta.

        Attachment #8677656 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: