1217661 - SeaMonkey build error: can't locate include file `PHeapSnapshotTempFileHelper.ipdl'

Status: RESOLVED WORKSFORME

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

+++ This bug was initially created as a clone of Bug #1217660 +++

1:05.01 c:\tb\5-central\src\mozilla\dom\ipc\PContent.ipdl:24: error: can't locate include file `PHeapSnapshotTempFileHelper.ipdl'

Probably from bug 1201597 and bug 912121

Comment 1

[Edmund Wong (:ewong)]

Apparently we need to also build devtools, and this is accomplished (afaik)
by adding MOZ_DEVTOOLS=all to confvars.sh.

Comment 2

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #1)
> Apparently we need to also build devtools, and this is accomplished (afaik)
> by adding MOZ_DEVTOOLS=all to confvars.sh.

tried that.  Not the right solution.. at least.. not the full solution.

Comment 3

[Robert Kaiser]

(In reply to Edmund Wong (:ewong) from comment #0)
> Probably from bug 1201597 and bug 912121

Those both landed a month ago, but we were not broken until today, right?

Comment 4

[Edmund Wong (:ewong)]

(In reply to Robert Kaiser (:[e-mail]) from comment #3)
> (In reply to Edmund Wong (:ewong) from comment #0)
> > Probably from bug 1201597 and bug 912121
> 
> Those both landed a month ago, but we were not broken until today, right?

Right..  As mentioned on irc, it's a bustage from https://hg.mozilla.org/mozilla-central/rev/3f174efd3a89.

Comment 5

[Robert Kaiser]

This makes my build succeed, not sure yet if we also need a package-manifest change in addition, though, I really should get to bed for today.

diff --git a/suite/app.mozbuild b/suite/app.mozbuild
--- a/suite/app.mozbuild
+++ b/suite/app.mozbuild
@@ -20,9 +20,10 @@ if CONFIG['MOZ_CALENDAR']:
     DIRS += [
         '/calendar/lightning',
         '/calendar/timezones'
     ]
 
 DIRS += [
     '/xpfe/components/autocomplete',
     '/suite',
+    '/devtools',
 ]

Comment 6

[Edmund Wong (:ewong)]

Attachment: proposed patch (v1)

Comment 7

[Edmund Wong (:ewong)]

Fwiw, this patch both builds and passes |make package|

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This situation might be resolved in bug 1217687 generally for all apps.

Comment 9

[Edmund Wong (:ewong)]

Attachment: proposed patch (v2)

Comment 10

[Edmund Wong (:ewong)]

Comment on attachment 8677944 [details] [diff] [review]
proposed patch (v2)

got rs+ bustagefix from NeilAway over IRC

Comment 11

[Edmund Wong (:ewong)]

Comment on attachment 8677944 [details] [diff] [review]
proposed patch (v2)

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/15fa117f0444

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I have pushed a more general fix in bug 1217687 which resumes adding /devtools through toolkit.  Once it lands, you'll likely need to revert the portion that added DIRS += [ '/devtools' ] in this bug to avoid a double including the directory (which I believe gives an error).

Sorry for all the trouble!

Comment 13

[Philip Chee]

Ah I already have a patch in Bug 1208112

Comment 14

[Edmund Wong (:ewong)]

Backed out as bug 1217687 fixed it in a generic way.

https://hg.mozilla.org/comm-central/rev/9eb1045b4f35