1217734 - Deleted duplicate home screens can be selected

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Teri Wen [:twen]]

When there are two same home screens available, delete one of them will delete both, but a radio button remains. Selecting the radio button will create a blank home screen. 

[Repro Steps]:
1. Install a home screen twice from webIDE
2. Go to Settings -> Home Screens -> Change Home Screen
3. Tap the installed home screen name for details
4. Tap delete button
5. Select the empty radio button

[Actual Result]: 
Radio button available for selection

[Expected Result]:
No radio button 

[Build Info]:
Build ID               20151023005002
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1f03a14106e59280761ac53904340f389674337f
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151023.001128
Firmware Date          Fri Oct 23 00:11:35 UTC 2015
Bootloader             s1

Comment 1

[Teri Wen [:twen]]

Nominate for blocking. Broken function.

Comment 2

[Chris Lord [:cwiiis]]

This bug is very clearly, going on the STR, manifesting in Settings, not Homescreen.

Comment 3

[Gregor Wagner [:gwagner]]

gmarty, can you take a look?

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1217734-Deleted-duplicate-home-screens-can-be-selected > mozilla-b2g:master

Comment 5

[Guillaume Marty [:gmarty]]

Comment on attachment 8678961 [details] [review]
[gaia] gmarty:Bug-1217734-Deleted-duplicate-home-screens-can-be-selected > mozilla-b2g:master

This patch makes sure that all apps with the same manifest URL are removed on uninstall. Fred, can you take a look?

Comment 6

[[e-mail]]

Comment on attachment 8678961 [details] [review]
[gaia] gmarty:Bug-1217734-Deleted-duplicate-home-screens-can-be-selected > mozilla-b2g:master

Thanks for the patch. As my test result the install related code seems need some tweaking as well.

I create an empty homescreen from WebIDE `previleged empty app`, add "role": "homescreen" in manifest.webapp, then:

1. go to Settings > Home Screens > Change Home Screen
2. Install a home screen twice from webIDE
there will be 2 dup entries on list

3. kill settings then re-enter the Change Home Screen panel
the dup entries are gone and leave correct single entry


And please add some test on https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/test/unit/modules/apps_cache_test.js to make sure others wont break it next time

Comment 7

[Guillaume Marty [:gmarty]]

Comment on attachment 8678961 [details] [review]
[gaia] gmarty:Bug-1217734-Deleted-duplicate-home-screens-can-be-selected > mozilla-b2g:master

Thanks for your feedback Fred. I removed the old comment and added a test for that fix. Can you review it again?

Comment 8

[[e-mail]]

Comment on attachment 8678961 [details] [review]
[gaia] gmarty:Bug-1217734-Deleted-duplicate-home-screens-can-be-selected > mozilla-b2g:master

The install related issue is addressed in bug 1217730, so this patch looks good to me. Thanks!

Comment 9

[Guillaume Marty [:gmarty]]

Landed in master in https://github.com/mozilla-b2g/gaia/commit/a498f875bb2fd248f1a46f3dfdd7695aadcd232f

Comment 10

[Teri Wen [:twen]]

Verified fixed. No duplicate home screen can be installed or deleted. 

Build ID               20151101012023
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/96377bdbcdf3e444a22aeaa677da696243b00d98
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151101.004008
Firmware Date          Sun Nov  1 00:40:17 UTC 2015
Bootloader             s1