Closed
Bug 1218129
Opened 9 years ago
Closed 9 years ago
XPInstallObserver.observe() generates JavaScript Error: "NS_NOINTERFACE: " @ browser.js - line: 5858
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Firefox 44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: capella, Assigned: vivek)
References
Details
Attachments
(1 file)
Currently points to: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js?rev=214bc95f9d20&mark=5858-5858#5842 Quick log shows related to: aSubject: [object ChromeWindow] aTopic: [browser-delayed-startup-finished]
Comment 1•9 years ago
|
||
Vivek, can you take a look at this?
Blocks: 1201547
Flags: needinfo?(vivekb.balakrishnan)
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1218129: Added instanceof check before call to QueryInterface r?margaret
Attachment #8678962 -
Flags: review?(margaret.leibovic)
Comment 3•9 years ago
|
||
https://reviewboard.mozilla.org/r/23287/#review20751 ::: mobile/android/chrome/content/browser.js:5863 (Diff revision 1) > - if (aSubject) { > + if (aSubject && aSubject instanceof Ci.amIWebInstallInfo) { I might be wrong, but I think instanceof _does_ a QueryInterface as well, so you might only need: installInfo = aSubject; Not a big deal either way.
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8678962 [details] MozReview Request: Bug 1218129: Added instanceof check before call to QueryInterface r?margaret Bug 1218129: Added instanceof check before call to QueryInterface r?margaret Thanks for that trick @mfinkle
Comment 5•9 years ago
|
||
Comment on attachment 8678962 [details] MozReview Request: Bug 1218129: Added instanceof check before call to QueryInterface r?margaret https://reviewboard.mozilla.org/r/23287/#review20761
Attachment #8678962 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/81d08a1039202a9966009ea282dea10a69bf68d2 Bug 1218129: Added instanceof check before call to QueryInterface r=margaret
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(vivekb.balakrishnan)
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/81d08a103920
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Updated•9 years ago
|
Assignee: nobody → vivekb.balakrishnan
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•