1218271 - panel specific styles should be defined in app.css or separated css

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Currently there are some panel specific styles defined in settings.css. 

We could move those panel specific styles into app.css so we can benefit from the lazyload of app.css.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1218271 > mozilla-b2g:master

Comment 2

[[e-mail]]

Comment on attachment 8679341 [details] [review]
[gaia] gasolin:issue-1218271 > mozilla-b2g:master

The patch may save some loadtime by lazy load 670 lines of styles.


1. moves inner panel styles into app.css (not change the original structure so we can make sure nothing is missing during migration)
2. fix wallpaper styles in settings_large.css (wallpaper has been moved to homescreens panel)

Will file a followup to re-organize styles in app.css

Comment 3

[[e-mail]]

note: #mediaStorage and .wallpaper are customized in settings_large.css, lazy load them in app.css may broke the tablet style (well I suppose it was somewhat broken now...). Therefore I left it in settings.css in this initial patch.

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8679341 [details] [review]
[gaia] gasolin:issue-1218271 > mozilla-b2g:master

Looks good see comment in PR. THanks!

Comment 5

[[e-mail]]

file bug 1219159 to fix developer HUD related issue

merged https://github.com/mozilla-b2g/gaia/commit/1419469702856533a82a3ce3069aad3403e09b00

thanks!