1218363 - nsIServiceWorkerManager should notify its listeners when a service worker is (un)registered.

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Eddy Bruel [:ejpbruel]]

We'd like to use ServiceWorkerManager to maintain a list of service worker registrations in the debugger server. However, unlike about:serviceworkers, which only refreshes the list when the user reloads the page, the debugger server is expected to notify its clients when the list of registrations changes.

To implement this, ServiceWorkerManager needs to emit an event when a service worker is (un)registered.

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: ServiceWorkerManager should emit an event when a service worker is (un)registered

Comment 2

[Eddy Bruel [:ejpbruel]]

Attachment: nsIServiceWorkerManager should notify its listeners when a service worker is (un)registered.

Fixed some minor bugs that I found in the patch, plus cleaned up the test to make it easier to read.

Comment 3

[Eddy Bruel [:ejpbruel]]

Catalin, could you take a look at this patch soon? It's been over a week since I put it up for review.

Comment 4

[Cătălin Badea (:catalinb)]

Comment on attachment 8682415 [details] [diff] [review]
nsIServiceWorkerManager should notify its listeners when a service worker is (un)registered.

Review of attachment 8682415 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/test_serviceworkermanager.xul
@@ +19,5 @@
> +              getService(Ci.nsIServiceWorkerManager);
> +
> +    function waitForIframeLoad(iframe) {
> +      return new Promise(function (resolve) {
> +        iframe.onload = function () {

nit: iframe.onload = resolve;

Comment 5

[Cătălin Badea (:catalinb)]

clearing ni, sorry for the delay.

Comment 6

[Eddy Bruel [:ejpbruel]]

Try run for this patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dcd704a66c2f

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e4244690d03

Comment 8

[Carsten Book [:Tomcat]]

backed out for m-oth bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=16785971&repo=mozilla-inbound

Comment 9

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72b526b94dee

Comment 10

[Eddy Bruel [:ejpbruel]]

(In reply to Carsten Book [:Tomcat] from comment #8)
> backed out for m-oth bustage like
> https://treeherder.mozilla.org/logviewer.html#?job_id=16785971&repo=mozilla-
> inbound

Ugh. I made a last minute change to one of the helper files before landing (I really shouldn't do that), and ended up removing it from the chrome.ini in the process. That's why the try run looked fine, but m-i did not.

All the other tests looked fine, so I think we can land this again with the chrome.ini issue resolved.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/317f1490ee1f

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/317f1490ee1f