Closed
Bug 1218365
Opened 9 years ago
Closed 4 years ago
Remove SSLErrorRunnable
Categories
(Core :: Security: PSM, defect, P3)
Core
Security: PSM
Tracking
()
RESOLVED
DUPLICATE
of bug 1498686
People
(Reporter: emk, Unassigned)
Details
(Whiteboard: [psm-backlog])
Attachments
(1 file)
|
3.62 KB,
patch
|
Details | Diff | Splinter Review |
We had to dispatch to the main thread because of nsISSLErrorListener. Since bug 844351 removed nsISSLErrorListener, I believe we could call nsHandleSSLError directly.
|
Reporter | |
Comment 1•9 years ago
|
||
|
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8678802 [details] [diff] [review] patch Oops, GetErrorLogMessage was main-thread only.
Attachment #8678802 -
Flags: review?(dkeeler)
Maybe it would be best to push the error logging (the reason for GetErrorLogMessage) more towards the front-end. Maybe (shudder) nsSecureBrowserUIImpl? Or some other thing that keeps track of loads and would be notified when something failed for a security reason. This will help move away from doing all of this error string formatting in PSM, which is not really where we want it.
Whiteboard: [psm-assigned]
P1 because this is assigned. If that changes, this is probably a P3.
Priority: -- → P1
|
||
Updated•7 years ago
|
Assignee: VYV03354 → nobody
Status: ASSIGNED → NEW
Priority: P1 → P3
Whiteboard: [psm-assigned] → [psm-backlog]
Handled this in bug 1498686.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•