Closed
Bug 1218868
Opened 9 years ago
Closed 8 years ago
Number buttons are taller and have the number shifted to the left when two SIMs are present
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gsvelto, Assigned: gsvelto)
Details
(Keywords: regression)
Attachments
(2 files)
When two SIMs are present the number button in a contact page shows the default SIM indicator on the right with three dots below it. However this also causes the button to be taller by 0.2rem than it should be and the number is shifted to the left by 0.4rem so it's not aligned any more with the phone type string that's just above it. I've attached a side-by-side screenshot with the two issues highlighted.
Assignee | ||
Comment 1•9 years ago
|
||
Also this is particularly jarring when opening a contact because there's a delay before the SIM indicator is shown and you can literally see the button "change" after a fraction of a second that you've opened the contact.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment 2•8 years ago
|
||
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8715238 [details] [review] [gaia] gabrielesvelto:bug-1218868-contacts-button-alignment-fix > mozilla-b2g:master This patch is doing something slightly different than I had anticipated. Besides adjusting the button height so it's consistently 4rem in height I've removed the rules that aligned the number so that it would start 1.5rem from the left and let it use the 1.2rem padding that all others buttons use. This way the contents of the number button are aligned to the contents of all the other buttons (and they're not different between the single-SIM and multi-SIM case). This was also tested in RTL mode and works correctly there too.
Attachment #8715238 -
Flags: review?(francisco)
Comment 4•8 years ago
|
||
Comment on attachment 8715238 [details] [review] [gaia] gabrielesvelto:bug-1218868-contacts-button-alignment-fix > mozilla-b2g:master lgtm, thanks Gabriele!
Attachment #8715238 -
Flags: review?(francisco) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Thanks for the review Francisco! Merged to gaia/master 9261ed36b29d6012d5866ee08e533feb5bfa0a57 https://github.com/mozilla-b2g/gaia/commit/9261ed36b29d6012d5866ee08e533feb5bfa0a57
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•