1218908 - Add 'Learn More...' link in notifications management dialog

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Comment 1

[Edwin Wong [:edwong]]

someone commented: Maybe we don't need this now that we are showing the Learn More content upon upgrade?

I would say - that will only display for users with existing allow notifications.

Comment 2

[Edwin Wong [:edwong]]

or help icon

Comment 3

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cad376d2e71f

Comment 5

[Matthew N. [:MattN]]

Landed without waiting for review due to string freeze and since it's pretty straightforward. Part of the change to the markup was to fix an existing problem with vertical alignment.

Comment 6

[Carsten Book [:Tomcat]]

had to back this out because this conflicts with the m-c to fx-team merge and block this because :

(run 'hg heads' to see heads, 'hg merge' to merge)
merging browser/components/preferences/in-content/content.js
merging browser/components/preferences/in-content/content.xul
warning: conflicts during merge.
merging browser/components/preferences/in-content/content.xul incomplete! (edit conflicts, then use 'hg resolve --mark')
merging browser/locales/en-US/chrome/browser/preferences/content.dtd
warning: conflicts during merge.
merging browser/locales/en-US/chrome/browser/preferences/content.dtd incomplete! (edit conflicts, then use 'hg resolve --mark')
236 files updated, 1 files merged, 8 files removed, 2 files unresolved
use 'hg resolve' to retry unresolved file merges or 'hg update -C .' to abandon

Comment 7

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/fx-team/rev/67ba7f84929a

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8680512 [details]
MozReview Request: Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

https://reviewboard.mozilla.org/r/23635/#review21151

Comment 9

[Matthew N. [:MattN]]

Comment on attachment 8680512 [details]
MozReview Request: Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/dc2d174f1f4a

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dc2d174f1f4a

Comment 12

[Matthew N. [:MattN]]

Comment on attachment 8680512 [details]
MozReview Request: Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

Approval Request Comment
[Feature/regressing bug #]: Notifications in Fx44
[User impact if declined]: No link to learn about what the notification permission is about
[Describe test coverage new/current, TreeHerder]: Nightly testing on m-c
[Risks and why]: Low risk following convention of other learn more links
[String/UUID change made/needed]: Yes, string landing before regular cut-off date

Comment 13

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f79375fd1d44

Comment 14

[Simona Badau, Desktop QA]

Verified that the "Learn More..." link was added in the notifications management dialog (in about:preferences#content).

Verified as fixed using the latest Firefox Nightly 45(Build ID: 20151103030248) and the latest Aurora 44 (Build ID: 20151103004217) on Ubuntu 14.04 x64, Windows 7x64 and Mac OS X 10.9:

Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0) Gecko/20100101 Firefox/45.0

Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:44.0) Gecko/20100101 Firefox/44.0

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/dc2d174f1f4a

Comment 16

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f79375fd1d44

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8680512 [details]
MozReview Request: Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

This has already landed on Aurora44 as part of blanket approval.