Closed Bug 1219097 Opened 9 years ago Closed 8 years ago

Intermittent browser_notification_open_settings.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect)

Product:
Toolkit Graveyard
Component:
Notifications and Alerts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 wontfix, firefox45 wontfix, firefox46 fixed, firefox47 fixed, firefox-esr45 unaffected)

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox44 --- wontfix
firefox45 --- wontfix
firefox46 --- fixed
firefox47 --- fixed
firefox-esr45 --- unaffected

People

(Reporter: philor, Assigned: mrbkap)

References

Details

(Keywords: intermittent-failure)

Attachments

(3 files)

Fix
13.89 KB, patch
Felipe
: review+
Details | Diff | Splinter Review
Fix newlines
15.46 KB, patch
Felipe
: review+
Details | Diff | Splinter Review
Merged patch for beta
23.30 KB, patch
Details | Diff | Splinter Review
Assignee: nobody → mrbkap
Attached patch Fix — — Splinter Review 
These tests use CPOWs incorrectly, leading to races and spurious failures. We can't simply use ContentTask because we need to hold state (the notification object) across a few calls to the content process, so I stuck it on the content window.
Attachment #8722729 - Flags: review?(felipc)
Attached patch Fix newlines — — Splinter Review 
There were some DOS newlines in here.
Attachment #8722730 - Flags: review?(felipc)
Blocks: 1239563
Attachment #8722729 - Flags: review?(felipc) → review+
Attachment #8722730 - Flags: review?(felipc) → review+
sorry had to back this out, this change here caused problems merging mozilla-central to mozilla-inbound 
warning: conflicts while merging browser/base/content/test/alerts/browser_notification_close.js! (edit, then use 'hg resolve --mark')
Flags: needinfo?(mrbkap)
I have no idea how that happened. Sorry about that!
Flags: needinfo?(mrbkap)
https://hg.mozilla.org/mozilla-central/rev/9460b1c1cccd
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
has problems/conflict on beta:

grafting 330506:9460b1c1cccd "Bug 1219097 - Stop using incorrect CPOWs in these tests. r=felipe"
merging browser/base/content/test/alerts/browser_notification_close.js
merging browser/base/content/test/alerts/browser_notification_do_not_disturb.js
merging browser/base/content/test/alerts/browser_notification_open_settings.js
merging browser/base/content/test/alerts/browser_notification_remove_permission.js
merging browser/base/content/test/alerts/browser_notification_tab_switching.js
merging browser/base/content/test/alerts/head.js
warning: conflicts while merging browser/base/content/test/alerts/browser_notification_close.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)
Flags: needinfo?(mrbkap)
Hi Carsten, please see the new patch for checkin to beta.
Flags: needinfo?(mrbkap) → needinfo?(cbook)
The merged patch doesn't apply cleanly to beta.
Flags: needinfo?(cbook)
Whiteboard: [checkin-needed-beta]
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: