Closed
Bug 1219163
Opened 9 years ago
Closed 9 years ago
Remove unused functions from AbstractMediaDecoder
Categories
(Core :: Audio/Video: Playback, defect, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(2 files)
AbstractMediaDecoder::NotifyDataArrived has no callers and can be removed. MediaDecoder::NotifyDataArrived has no overrides and can be devirtualized.
Assignee | ||
Comment 1•9 years ago
|
||
Correction: MediaDecoder::NotifyDataArrived implements MediaResourceCallback and can't be devirtualized. We will remove AbstractMediaDecoder::NotifyDataArrived only.
Assignee: nobody → jwwang
Summary: Devirtualize MediaDecoder::NotifyDataArrived → Remove AbstractMediaDecoder::NotifyDataArrived
Assignee | ||
Comment 2•9 years ago
|
||
In fact, we will clean up unused functions of AbstractMediaDecoder.
Summary: Remove AbstractMediaDecoder::NotifyDataArrived → Remove unused functions from AbstractMediaDecoder
Updated•9 years ago
|
Priority: -- → P2
Assignee | ||
Comment 3•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d5376f96b4e
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1219163. Part 1 - Remove unused functions from AbstractMediaDecoder. r=jya.
Attachment #8690610 -
Flags: review?(jyavenard)
Assignee | ||
Comment 5•9 years ago
|
||
Bug 1219163. Part 2 - Move some functions that are never called from the interface of AbstractMediaDecoder down the class hierarchy. r=jya.
Attachment #8690611 -
Flags: review?(jyavenard)
Comment 6•9 years ago
|
||
Comment on attachment 8690610 [details] MozReview Request: Bug 1219163. Part 1 - Remove unused functions from AbstractMediaDecoder. r=jya. https://reviewboard.mozilla.org/r/25879/#review23275
Attachment #8690610 -
Flags: review?(jyavenard) → review+
Comment 7•9 years ago
|
||
Comment on attachment 8690611 [details] MozReview Request: Bug 1219163. Part 2 - Move some functions that are never called from the interface of AbstractMediaDecoder down the class hierarchy. r=jya. https://reviewboard.mozilla.org/r/25881/#review23277
Attachment #8690611 -
Flags: review?(jyavenard) → review+
Assignee | ||
Comment 8•9 years ago
|
||
Thanks for the review!
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebce560d20ac https://hg.mozilla.org/integration/mozilla-inbound/rev/1911381f3f89
Comment 10•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ebce560d20ac https://hg.mozilla.org/mozilla-central/rev/1911381f3f89
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•