1219732 - Addon test not ready to run with JPM

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect)

Description

[Jacobo Aragunde Pérez]

User Agent: Mozilla/5.0 (Fedora; Linux x86_64) AppleWebKit/601.1 (KHTML, like Gecko) Version/8.0 Safari/601.1 Epiphany/3.16.3

Steps to reproduce:

Ran tests with gulp test:addons



Actual results:

Several warnings and one error appear when running the page-worker addon:

JPM [warning] Either a `title` or `name` property should be specified in `package.json`
as the addon's displayable name on AMO.

JPM [warning] The `name` field in `package.json` should contain only lowercase
alphanumeric characters, underscore, dot, or dashes, and cannot
start with an underscore or dash, to be compatible with npm
naming conventions.

JPM [warning] The `version` entry must be specified, and it should follow semantic
versioning rules. For example, it must be a string containing three
values indicating major, minor, and patch versions. For example:

"1.4.56"
"0.0.1"
"1.0.0rc4"

http://semver.org

JPM [error] Error: A valid identification must be defined in `package.json` to be
able to be installed by Firefox. Adding a `name` field to the
`package.json` works as identification, or an `id` property that
is formatted as a GUID or address, like:

  '{930a4f32-54e4-109c-929b-9209abc8de4f}'
  'myextension@jetpack'
  '[e-mail]'

IF MOVING FROM CFX: The cfx tool adds `@jetpack` to your `id` field
if invalid -- to transition to jpm, adding `@jetpack` will fix the issue,
and also retain the same ID used on AMO.

Comment 1

[Jacobo Aragunde Pérez]

When I addressed the error and warnings mentioned above, I got this other error:


JPM [error] Error: The addon has no valid entry point. Either create an entry point
at `./index.js`, or set the `main` property to a valid path in
your addon.

Comment 2

[Jacobo Aragunde Pérez]

Attachment: Pull request

Comment 3

[Jacobo Aragunde Pérez]

Any chance to get the patch reviewed? If necessary, I can submit it through other means. Thanks in advance!

Comment 4

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562