Closed Bug 1220476 Opened 9 years ago Closed 9 years ago

Make --disable-compile-environment on mobile/android work without the Android NDK

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

Bug 1159371 and friends made --disable-compile-environment work for --enable-application=mobile/android.  Unfortunately, we still configure (and use parts of?) the Android NDK toolchain.

This ticket tracks making mobile/android builds work we have no compile environment and no --with-android-ndk configured in the mozconfig.
Bug 1220476 - Make --disable-compile-environment work without an Android NDK. r?glandium
Attachment #8682261 - Flags: review?(mh+mozilla)
I just tested an artifact build with --target=i386-linux-android and it produced an APK that looks good, but I don't have an x86 device to test right now.  I tested --target=arm-linux-androideabi earlier.
Comment on attachment 8682261 [details]
MozReview Request: Bug 1220476 - Make --disable-compile-environment work without an Android NDK. r?glandium

https://reviewboard.mozilla.org/r/24023/#review21457

::: configure.in:1259
(Diff revision 1)
> +    MOZ_ARCH=armv7-a

Seems to me this should be in a else alternative to MOZ_ARCH_OPTS, which then allows to not duplicate MOZ_ANDROID_CPU_ARCH here.
Attachment #8682261 - Flags: review?(mh+mozilla)
Comment on attachment 8682261 [details]
MozReview Request: Bug 1220476 - Make --disable-compile-environment work without an Android NDK. r?glandium

Bug 1220476 - Make --disable-compile-environment work without an Android NDK. r?glandium
Attachment #8682261 - Flags: review?(mh+mozilla)
Comment on attachment 8682261 [details]
MozReview Request: Bug 1220476 - Make --disable-compile-environment work without an Android NDK. r?glandium

https://reviewboard.mozilla.org/r/24023/#review21463
Attachment #8682261 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/fx-team/rev/b423610b2e44ba5b63458608d4f78c979d970e77
Bug 1220476 - Make --disable-compile-environment work for Android builds without an Android NDK. r=glandium
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Blocks: 1221200
https://hg.mozilla.org/mozilla-central/rev/b423610b2e44
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Depends on: 1222544
Depends on: 1228256
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: