1220680 - Compare view needs to link to graphs

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

We took out the graphs because they don't make sense for try, but they definitely make sense for other repos. Let's put them back in with some intelligence about what link to display in different cases. Proposal:

1. Both try -- don't show graph link
2. One try, one non-try -- show graph link for non-try only
3. Both non-try -- show graph link for both (possibly displaying two series if comparing one repo against another)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I would prefer in #3 to show them on the same graph :)

Comment 2

[William Lachance (:wlach)]

Attachment: PR

This adds links to graphs from the compare view when you hover (both in the main compare view and the subtest view).

I decided to actually show the graphs for try as well, as I found it could be helpful since you could compare the highlighted results against the base series in context.

There are some related fixes as well:

* Graphs view now loads correctly if you provide a revision that doesn't map to a result set in a series (probably didn't happen much in the past, but can easily happen here)
* Reduce the amount of visual noise in the compare view by default (only underline things and present links on hover)

Examples:

http://wlach.github.io/treeherder/ui/perf.html#/comparesubtest?originalProject=mozilla-central&originalRevision=bb4d614a0b09&newProject=mozilla-inbound&newRevision=173b3daa4344&originalSignature=68ee29511b6d44d87ac1cb2a511d2951ca0d440d&newSignature=68ee29511b6d44d87ac1cb2a511d2951ca0d440d

http://wlach.github.io/treeherder/ui/perf.html#/compare?originalProject=mozilla-inbound&originalRevision=4744545d275c&newProject=try&newRevision=342bfed777a3&showOnlyImportant=0

bwinton: adding you for feedback because we discussed this a bit yesterday, but don't feel obligated unless you have time

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8682638 [details] [review]
PR

I am not sure about the .css changes, I am glad to see that you handle putting both revisions on the same graph link!

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8682638 [details] [review]
PR

f=me with the nit that I mentioned before fixed…  ;)

Comment 5

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/adedad55c8e352fea88d72f701820b61b586304d
Bug 1220680 - Make detail highlighting more consistent / subtle in compare view

* low/medium/high confidence explanation now uses same tooltip as the other
  elements
* we now only underline the currently hovered row

https://github.com/mozilla/treeherder/commit/36e27df932fbe2aa7d2e9a82ae7f22c5d532e7ee
Bug 1220680 - Fix handling of non-existent revisions in perfherder graphs

Specfically, handle the case where no resultset exists for a highlighted
revision in a series when graphs are first loaded. Note that sometimes a
revision might be valid in one series but not another.

https://github.com/mozilla/treeherder/commit/edf7548545deed9f00b68cac2fe318a1b85da80f
Bug 1220680 - Add links to graphs from compare view

As long as there is at least one non-try repo in the comparison view,
we should allow users to visualize results on a graph.

Comment 6

[William Lachance (:wlach)]

Pushed with bwinton's nit addressed!