1220773 - Expose Android getInstallerPackageName within Fennec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Richard Newman [:rnewman]]

PackageManager.getInstallerPackageName returns the package that installed us. We can use this to determine if we were sideloaded or installed via Play (or Amazon, or F-Droid, or…).

This will allow us to tailor our updater behavior, amongst other things.

Things to check:

* Do we always get a package name on all Android versions?
* What happens when we're preinstalled but expect to be updated via Play?
* Does the package change each time an APK is installed? For example, is it null for the preinstall, then change to com.android.vending after the first Play update?
* Can it change back to null if a user sideloads after installing via Play?

We might consider exposing this value literally to Balrog in update checks.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

I wonder if we could use Telemetry to get an idea of what getInstallerPackageName() returns for devices in the wild. Is this feasible?

(In reply to Richard Newman [:rnewman] from comment #0)
> We might consider exposing this value literally to Balrog in update checks.

Could we use this to get the same statistics?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sebastian Kaspari (:sebastian) from comment #1)
> I wonder if we could use Telemetry to get an idea of what
> getInstallerPackageName() returns for devices in the wild. Is this feasible?

Seems like rnewman already filed this: bug 1221646

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1220773 - Do not run our updater if app was installed from Google Play.

Review commit: https://reviewboard.mozilla.org/r/67134/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67134/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

I still need to test this extensively (I'll probably have to fake some of the data) but I already share the patch to get your feedback.

Comment 5

[Eugen Sawin [:esawin]]

Comment on attachment 8774689 [details]
Bug 1220773 - Do not run our updater if app was installed from Google Play.

https://reviewboard.mozilla.org/r/67134/#review63964

::: mobile/android/base/java/org/mozilla/gecko/updater/UpdateServiceHelper.java:135
(Diff revision 1)
>              Log.e(LOGTAG, "Failed to create update url: ", e);
>              return null;
>          }
>      }
>  
> -    public static boolean isUpdaterEnabled() {
> +    public static boolean isUpdaterEnabled(Context context) {

Can be final.

Comment 6

[Andrzej Hunt :ahunt]

Comment on attachment 8774689 [details]
Bug 1220773 - Do not run our updater if app was installed from Google Play.

https://reviewboard.mozilla.org/r/67134/#review64120

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8774689 [details]
Bug 1220773 - Do not run our updater if app was installed from Google Play.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67134/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64c473c3414f
Do not run our updater if app was installed from Google Play. r=ahunt,esawin

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/64c473c3414f