122081 - Universalchardet leaks memory

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Takayuki Tamura]

The universal_charset_detector always leaks memory at its deallocation due to
the broken destructor chain.
I happened to notice the fact while running a standalone program which processed
a large set of files via the component in a one instance per file manner.
(The program essentially is an infinite loop version of the UniversalChardetTest.)

The offending class is nsCharSetProber, the base class of many other Prober
classes, and the missing virtual destructor in the class prevents the invocation
of the derived classes' destructors.

The patch will follow.

Comment 1

[Takayuki Tamura]

Attachment: Fix for memleaks in the universalchardet module

The fix for the nsCharSetProber class declaration, plus fix for
nsUniversalDetector methods, which may cause another leak when the object is
reused after Reset().

Comment 2

[Frank Tang]

pass to shanjian

Comment 3

[Shanjian Li]

Comment on attachment 66671 [details] [diff] [review]
Fix for memleaks in the universalchardet module

r=shanjian

Comment 4

[Shanjian Li]

brendan, could you sr? 

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 66671 [details] [diff] [review]
Fix for memleaks in the universalchardet module

sr=[e-mail]

/be

Comment 6

[Vidar Haarr (not reading bugmail)]

This patch needs to be checked in as soon as possible.
it is a no-brainer, can we get this for 0.9.9 ?

Comment 7

[Shanjian Li]

Because there are too many checkin yesterday, all checkins have to be metered.
Unfortunately, I did not got the permission to check in this patch. I will try
it for 1.0. 

Comment 8

[Frank Tang]

nsbeta1+, shanjian- do we have the same problem in the all detector. if so,
please open a bugscape bug and fix that (mark nsbeta1)

Comment 9

[Brendan Eich [:brendan]]

Shanjian, just check it in when the tree opens later today for approved 0.9.9
checkins (it's now closed for smoketest blocker fixing only),
a=[e-mail] on behalf of drivers.

/be

Comment 10

[Shanjian Li]

fix checked in. 

Comment 11

[Shanjian Li]

marked as fixed.

Comment 12

[Yuying Long]

Seems works fine with me on latast trunk build, mark as verified.  Please
re-open if still see the problem.