Closed
Bug 1221418
Opened 9 years ago
Closed 8 years ago
Assertion failure: mActorDestroyed, at dom/asmjscache/AsmJSCache.cpp
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: jruderman, Assigned: baku)
Details
(Keywords: assertion, testcase)
Attachments
(3 files, 2 obsolete files)
Assertion failure: mActorDestroyed, at dom/asmjscache/AsmJSCache.cpp:1277
|
Reporter | |
Comment 1•9 years ago
|
||
|
||
Comment 2•9 years ago
|
||
Guessing this is a regression from bug 1173756?
|
||
Comment 3•9 years ago
|
||
(In reply to Luke Wagner [:luke] from comment #2) > Guessing this is a regression from bug 1173756? Yeah, if BlockUntilOpen() fails early then the IPC protocol is not created and mActorDestroyed is not cleared. I'll fix it.
|
Assignee | |
Comment 4•8 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8705601 -
Flags: review?(jvarga)
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8705601 [details] [diff] [review] bug_asmjs_1221418.patch Review of attachment 8705601 [details] [diff] [review]: ----------------------------------------------------------------- I don't understand this fix, mActorDestroyed(true) by default ? I would rather do: 1. Create NoteActorDestroyed() method that sets mActorDestroyed to true 2. Create Cleanup() method that calls NoteActorDestroyed(), the call can be #ifdef DEBUG'ed since it's only useful to silent the assertion in the destructor 3. Update ActorDestroyed() to call NoteActorDestroyed() instead of setting the flag directly 4. Add childRunnabled->Cleanup() if BlockUntilOpen() fails
Attachment #8705601 -
Flags: review?(jvarga)
|
|
Assignee | |
Comment 6•8 years ago
|
||
> I don't understand this fix, mActorDestroyed(true) by default ?
what's the point to have mActorDestroyed(false) by default if we don't have an actor yet?|
|
Assignee | |
Comment 7•8 years ago
|
||
Attachment #8705601 -
Attachment is obsolete: true
Attachment #8705615 -
Flags: review?(jvarga)
|
|
Assignee | |
Comment 8•8 years ago
|
||
Attachment #8705615 -
Attachment is obsolete: true
Attachment #8705615 -
Flags: review?(jvarga)
Attachment #8705619 -
Flags: review?(jvarga)
|
|
||
Comment 9•8 years ago
|
||
Comment on attachment 8705619 [details] [diff] [review] bug_asmjs_1221418.patch Review of attachment 8705619 [details] [diff] [review]: ----------------------------------------------------------------- Muchas gracias!
Attachment #8705619 -
Flags: review?(jvarga) → review+
|
||
Comment 11•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/273505970b6c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•