1221427 - [TV Browser] Failed to go back to one-up level after tapping the Back button in Bookmarks list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

Description

[Cynthia Tang [:cynthiatang]]

Attachment: [TV]FirefoxAccount_v0.5

Commit f17421e9a23b9dbd88c41347f1b9c442a97f48e0
Merge: 06de78d e7dd557
Author: gasolin <[e-mail]>
Date:   Tue Nov 3 13:37:26 2015 +0800

STR:
 1. Launch Browser
 2. Sign in to Sync
 3. Go to "Show your bookmarks"
 4. Select a site in your bookmarks
 4. Press Back on the remote control 
    (Press ESC key on the physical keyboard)

Expected Result:
 - It will go back to one-up level
 - Please refer [TV]FirefoxAccount_v0.5, page 11

Actual Result:
 - Nothing happens

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Side note: pressing back space key closes the bookmarks menu. Not sure if that's expected. YiFan, this seems to be another key navigation issue, could you take it, please? Thanks!

Comment 2

[yifan [:yifan][:yliao]]

Thanks! Dan please add the escape key handler in the smart list.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1221420_back_button_support_in_smartList > mozilla-b2g:master

Comment 4

[Dan Huang[:danhuang]]

Comment on attachment 8687024 [details] [review]
[gaia] danhuang1202:1221420_back_button_support_in_smartList > mozilla-b2g:master

Hi Yi-fan, please help review. This patch add escape key support in smartList. Thanks.

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8687024 [details] [review]
[gaia] danhuang1202:1221420_back_button_support_in_smartList > mozilla-b2g:master

LGTM! I leave some comments for the nits. Please fix them before landing. Thanks for the effort.

Comment 6

[Sean Lee [:seanlee][:weilonge]]

The bug # in PR's comment is incorrect. Please fix the comment in your PR. Thanks.

Comment 8

[Dan Huang[:danhuang]]

revise commit log to 'Bug 1221427  - Support ecape key in smartlist. r=seanlee'

Comment 9

[Dan Huang[:danhuang]]

Thanks for the review.
Merge in master: https://github.com/mozilla-b2g/gaia/commit/3f3637aede6a59d8f184305f34c4da0830c8fe5a

Comment 10

[Dan Huang[:danhuang]]

Comment on attachment 8687024 [details] [review]
[gaia] danhuang1202:1221420_back_button_support_in_smartList > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 824026
[User impact] if declined: the back button couldn't work in remote control.
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b6aac7aa647d6f65c7634e3946b77e600613f5a3
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

Comment 11

[Josh Cheng [:josh]]

Comment on attachment 8687024 [details] [review]
[gaia] danhuang1202:1221420_back_button_support_in_smartList > mozilla-b2g:master

Approve for TV Browser 2.5

Comment 12

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/e5ef32f13e1a417f585dcc537c521eb3afaf5cb4

Comment 13

[Cynthia Tang [:cynthiatang]]

Verified.

=======  Passed in Master branch  ==================== 
commit ff662257263e9d71f8202d9d61a1b2035944e346
Merge: af7fe55 ae5cbee
Author: Johan Lorenzo <[e-mail]>
Date:   Fri Dec 4 12:26:37 2015 +0100

=======  Passed in v2.5 branch ==================== 
Commit 2d54c29f429bed790b5d8284633812dc2b782518
Author: Fischer.json <[e-mail]>
Date:   Mon Nov 30 15:06:13 2015 +0800