Closed
Bug 1221688
Opened 9 years ago
Closed 8 years ago
Create custom UIMenuItem action for revealing the password
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fxios | 2.0+ | --- |
People
(Reporter: sleroux, Assigned: sleroux, Mentored)
References
Details
(Whiteboard: [good first bug][needstrings])
Attachments
(2 files)
20.30 KB,
image/png
|
Details | |
48 bytes,
text/x-github-pull-request
|
bnicholson
:
review+
tecgirl
:
ui-review+
|
Details | Review |
By default, the password field in the login detail view will be password-ized with dots. When the selects it, we should display a copy and reveal option that shows the password in plain text. Looks like we can add a custom item to the selection menu using UIMenuController http://nshipster.com/uimenucontroller/ https://developer.apple.com/library/prerelease/ios/documentation/iPhone/Reference/UIMenuController_Class/index.html
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Mentor: sleroux
Whiteboard: [good first bug]
Assignee | ||
Updated•8 years ago
|
Whiteboard: [good first bug] → [good first bug][needstrings]
Assignee | ||
Comment 2•8 years ago
|
||
Flagging bnicholson since Emily's on PTO
Attachment #8701143 -
Flags: review?(etoop)
Attachment #8701143 -
Flags: review?(bnicholson)
Assignee | ||
Comment 3•8 years ago
|
||
Note: This PR also includes https://bugzilla.mozilla.org/show_bug.cgi?id=1221693. Was easier to do it all in one go.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8701143 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1382 :tecgirl I forgot to flag you for a UI review on the login detail screen. You can check it as part of this if you want as this includes the menu actions (no editing though).
Attachment #8701143 -
Flags: ui-review?(randersen)
Updated•8 years ago
|
Attachment #8701143 -
Flags: ui-review?(randersen) → ui-review+
Comment 5•8 years ago
|
||
Comment on attachment 8701143 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1382 Looks good! Just a few notes in the PR.
Attachment #8701143 -
Flags: review?(bnicholson) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Thanks for the double pass on this. I've fixed up the nits and included the settings delegate (with test!) to this PR as well.
Assignee | ||
Comment 7•8 years ago
|
||
Landed master b98103973b5ccfd9b2008eb29bb04de54f862c73
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Attachment #8701143 -
Flags: review?(etoop)
You need to log in
before you can comment on or make changes to this bug.
Description
•