Closed
Bug 1221949
Opened 9 years ago
Closed 9 years ago
Stop button reloads the page on iPad devices
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: csuciu, Assigned: st3fan)
Details
(Keywords: reproducible)
Attachments
(1 file)
Build: Beta 1113 iPad Air 2 (9.1) Stop button ([X]) reloads the page instead of stop loading it Note: Not reproducible on iPhone 6 Plus (iOS 9.1)
|
||
Comment 1•9 years ago
|
||
Silly. Reproducible.
Keywords: reproducible
Summary: 'Stop' button reloads the page → 'Stop' button reloads the page on iPad devices
|
Assignee | |
Updated•9 years ago
|
|
|
Assignee | |
Updated•9 years ago
|
Summary: 'Stop' button reloads the page on iPad devices → Stop button reloads the page on iPad devices
|
|
Assignee | |
Comment 2•9 years ago
|
||
This patch transfers the `isLoading` state to the `BrowserToolbarHelper`, which is the component that deals with presses on the Stop/Reload button. Without the state transferred, it always thinks it needs to reload the page.
Attachment #8683982 -
Flags: review?(rnewman)
|
|
Assignee | |
Comment 3•9 years ago
|
||
A good page to test this on is http://deelay.me - it loads some images incrementally, delayed, so you have plenty of time to interrupt the page load.
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8683982 [details] [review] PR: https://github.com/mozilla/firefox-ios/pull/1226 LGTM. (And by G I mean B.)
Attachment #8683982 -
Flags: review?(rnewman) → review+
|
|
||
Updated•9 years ago
|
Assignee: nobody → sarentz
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 5•9 years ago
|
||
Verifying as fixed on Beta 1202
Status: RESOLVED → VERIFIED
Flags: needinfo?(catalin.suciu)
You need to log in
before you can comment on or make changes to this bug.
Description
•