1221999 - Improve reviewer parsing from commit summaries

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Dan Minor [:dminor]]

We'll need to improve things when we start rewriting commits. This will also help with the work to re-request reviews using r?.

Comment 1

[:glob ✱]

Attachment: MozReview Request: mozautomation: Rework parse_reviewers to improve logic (Bug 1221999); r?gps

mozautomation: Rework parse_reviewers to improve logic (Bug 1221999); r?gps

Rewrite the reviewer parsing code so it handles unusual syntax.  Matching
reviewers in a single regex makes it trivial to perform operations such as
replacing matched reviewers.

Comment 2

[:glob ✱]

Comment on attachment 8684043 [details]
MozReview Request: mozautomation: Rework parse_reviewers to improve logic (Bug 1221999); r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24483/diff/1-2/

Comment 3

[:glob ✱]

debuggex link for the REVIEWERS_RE regex: https://www.debuggex.com/r/vhh8zeXwBYH14pJO

this change also fixes the following bugs:

bug 1182143
  https://hg.mozilla.org/try/rev/8eb2bf70a81c => 'hsinyi'

bug 1171984
  https://hg.mozilla.org/mozilla-central/rev/b0a0287517d2 => (empty array)  

bug 1191742
  https://hg.mozilla.org/mozilla-central/rev/1416eeab79a2 => 'bsmedberg'

bug 1194349
  http://hg.mozilla.org/mozilla-central/rev/91d6e262b662 => 'ehsan'

bug 1220669
  https://hg.mozilla.org/integration/fx-team/rev/c66c3620de84 => 'maritz', 'gijs'
  https://hg.mozilla.org/integration/fx-team/rev/85bd262e7094 => 'mikedeboer'
  https://hg.mozilla.org/integration/fx-team/rev/84df75fc0206 => 'billm', 'bwinton'

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8684043 [details]
MozReview Request: mozautomation: Rework parse_reviewers to improve logic (Bug 1221999); r?gps

https://reviewboard.mozilla.org/r/24483/#review22111

I would have been terrified to review this if the test coverage weren't so good.

You can always count on a Perl guru being able to solve complicated parsing problems like this with regular expressions :D. Nice work.

Comment 10

[:glob ✱]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/361c7d0f6a40