Closed Bug 1222016 Opened 9 years ago Closed 8 years ago

[TV Browser] There should be a pop-up window if user disconnect successfully

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P3)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
VERIFIED FIXED
Milestone:
2.6 S2 - 12/4
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: cynthiatang, Assigned: yifan)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick])

Attachments

(5 files)

[TV]FirefoxAccount_v0.5
112 bytes, text/plain
Details
[gaia] begeeben:1222016_there_should_be_a_pop_up > mozilla-b2g:master
46 bytes, text/x-github-pull-request
ferjm
: review+
jocheng
: approval-gaia-v2.5+
Details | Review
[gaia] begeeben:uplift/1222016_2.5 > mozilla-b2g:v2.5
46 bytes, text/x-github-pull-request
Details | Review
[gaia] begeeben:1222016_only_show_when_logged_in > mozilla-b2g:master
46 bytes, text/x-github-pull-request
ferjm
: review+
jocheng
: approval-gaia-v2.5+
Details | Review
[gaia] begeeben:uplift/1222016_2 > mozilla-b2g:v2.5
46 bytes, text/x-github-pull-request
Details | Review 
============== Gaia Information ==============
commit f17421e9a23b9dbd88c41347f1b9c442a97f48e0
Merge: 06de78d e7dd557
Author: gasolin <gasolin@gmail.com>
Date:   Tue Nov 3 13:37:26 2015 +0800

STR:
 1. Launch Browser
 2. Sign in to Sync
 3. Press "Disconnect" to sign out 

Expected Result:
 - There is a pop-up window that shows "You have signed out successfully."
 - User can press OK/Enter  

Actual Result:
 - No pop-up window

Reference: [TV]FirefoxAccount_v0.5, page 17
QA Whiteboard: [COM=TV Firefox Account]
Function missing. Set it to higher priority.
Assignee: nobody → yliao
Priority: P3 → P1
blocking-b2g: --- → 2.5+
Comment on attachment 8692413 [details] [review]
[gaia] begeeben:1222016_there_should_be_a_pop_up > mozilla-b2g:master

The patch displays a sign out successful dialog.
Attachment #8692413 - Flags: review?(ferjmoreno)
Status: NEW → ASSIGNED
Attachment #8692413 - Flags: review?(ferjmoreno) → review+
Blocks: fxos-sync
Target Milestone: --- → 2.6 S2 - 12/4
Priority: P1 → P3
Merged into master:
https://github.com/mozilla-b2g/gaia/commit/ef452b89c76e47d27584c15996aa03da2a716531
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
Comment on attachment 8692413 [details] [review]
[gaia] begeeben:1222016_there_should_be_a_pop_up > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1194108
[User impact] if declined: A user will not notice when the sign out process is success. 
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=126c01dbc9cb5ab7e997251de07eb3980e373184
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none
Attachment #8692413 - Flags: approval-gaia-v2.5?
Comment on attachment 8692413 [details] [review]
[gaia] begeeben:1222016_there_should_be_a_pop_up > mozilla-b2g:master

Approve for TV 2.5
Attachment #8692413 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
has problems during uplift:

Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 0d97e848e00e67445ab8c3e0f8165b38e5a3ace7
error: could not apply 0d97e84... Bug 1222016 - [TV Browser] There should be a pop-up window if user disconnect successfully
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
Flags: needinfo?(yliao)
Patch for v2.5 created. Thanks!
Flags: needinfo?(yliao) → needinfo?(cbook)
Depends on: 1223273
Hi YiFan,
Please watch the video https://youtu.be/Jw0g2tWV_ks . Could you please help check this commit?

STR:
 1. Launch Browser
 2. Go to Menu > Select "Sign in to Sync" > Press OK
 3. Press Back

Actual result:
 - The window "You have signed out successfully" popped up


Expected result:
 - Go back to the previous page after pressing Back


========= Result: Failed ========================
Commit: ef452b89c76e47d27584c15996aa03da2a716531 [ef452b8]
Parents: b04e417b7b, 0d97e848e0
Author: Yi-Fan Liao <yliao@mozilla.com>
Date: 2015年11月30日 GMT+816:10:05秒

Merge pull request #33381 from begeeben/1222016_there_should_be_a_pop_up

Bug 1222016 - [TV Browser] There should be a pop-up window if user disconnect successfully, r=ferjm


========= Result: Passed ========================
Commit: b04e417b7b45ec561a45437bb103b0134eaad44f [b04e417]
Parents: 1c2997569d, 8bc52a7c3f
Author: danhuang1202 <dhuang@mozilla.com>
Date: 2015年11月30日 GMT+816:05:26秒

Merge pull request #33412 from danhuang1202/1223273_revise_fxa_offline_error_message

Bug 1223273 - Revise l10n string of fxa offline error message. r=yifan
Status: RESOLVED → REOPENED
Flags: needinfo?(yliao)
Resolution: FIXED → ---
Blocks: TV_P1
(In reply to Carsten Book [:Tomcat] from comment #13)
> reverted in
> https://github.com/mozilla-b2g/gaia/commit/
> 7ca639a7bb0bacf27f548841c52617bfc0e3b21f

Hi Carston,
Could you also help to update "status-b2g" when you land or revert the patch? ("affected" to "fixed" or the other way around)
It would help help us understand the current patch status on certain release. Thanks!
Flags: needinfo?(cbook)
(In reply to Josh Cheng [:josh] from comment #14)
> (In reply to Carsten Book [:Tomcat] from comment #13)
> > reverted in
> > https://github.com/mozilla-b2g/gaia/commit/
> > 7ca639a7bb0bacf27f548841c52617bfc0e3b21f
> 
> Hi Carston,
> Could you also help to update "status-b2g" when you land or revert the
> patch? ("affected" to "fixed" or the other way around)
> It would help help us understand the current patch status on certain
> release. Thanks!

yeah sorry missed this here
Flags: needinfo?(cbook)
Comment on attachment 8701007 [details] [review]
[gaia] begeeben:1222016_only_show_when_logged_in > mozilla-b2g:master

This patch checks if a user has logged in before disabling sync. Thanks you for the review!
Flags: needinfo?(yliao)
Attachment #8701007 - Flags: review?(ferjmoreno)
Attachment #8701007 - Flags: review?(ferjmoreno) → review+
Thanks! Revised according to the comment.
Merged into master: https://github.com/mozilla-b2g/gaia/commit/a07d62b8c3544794e5f7d46bfb39cd97ef59f568
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
Resolution: --- → FIXED
Comment on attachment 8701007 [details] [review]
[gaia] begeeben:1222016_only_show_when_logged_in > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Unexpected logged out successful dialog.
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=3a79889ce0ebe005eca701b265086ea9e9198bdf
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none
Attachment #8701007 - Flags: approval-gaia-v2.5?
Comment on attachment 8701007 [details] [review]
[gaia] begeeben:1222016_only_show_when_logged_in > mozilla-b2g:master

Approve for TV 2.5
Attachment #8701007 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
this has conflicts uplifting to 2.5 Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick c3b50ad965de09fb2278c4f89514622522f18267
error: could not apply c3b50ad... Bug 1222016 - [TV Browser] There should be a pop-up window if user disconnect successfully
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

can you take a look ?
Flags: needinfo?(yliao)
Please try the attached patch for 2.5, thanks.
Flags: needinfo?(yliao) → needinfo?(cbook)
thanks yifan that worked! many thanks for all the help in 2015 !

commited as https://github.com/mozilla-b2g/gaia/commit/37f0119c1c0767962060b25c898c6caaf7f08c04 to 2.5
status-b2g-v2.5: affected → fixed
Flags: needinfo?(cbook)
Verify this issue on the latest build.
1. After signing out, the message "You have signed out successfully." pops up. And then pressing the OK button will back to the Browser Settings page.
2. After signing in and the message "Success! Your Firefox Account is ready to go!" pops up, pressing the Back key and the screen will back to the Browser Settings page.

[Build Info]
Environment: Simulator 2.5.20160215231509
gaia:
https://github.com/mozilla-b2g/gaia/commit/b059a19c4cb615e16174735662199e6769cee393
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/227c6d4926c154167a2214e123253f2c937e4106
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3

[Build Info]
Environment: Simulator 2.6.20160222133739
gaia:
https://github.com/mozilla-b2g/gaia/commit/435a9320454ccc3ffdebff4d5d680f1254a15e26
gecko:
https://hg.mozilla.org/mozilla-central/rev/a9e33d8c48b5ca93ca1937eba4220f681a0f05ec
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: