Closed Bug 1222057 Opened 9 years ago Closed 9 years ago

Homescreen dialogs should be combined

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

References

(
URL
)

Details

I see a lot of similar code in:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/homescreen/regions/

I have 2 thing
- Perhaps we could combine these dialog in 1 general dialog from which we can work on?
- I think it makes more sense if these were part of the system app region, because these are system dialogs

Johan, what do you think?
Flags: needinfo?(jlorenzo)
I totally agree! IIRC, the bookmark menu[1] should disappear with bug 1217404. All the rest can be in 1 class with methods like: confirm() and cancel().

[1] http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/homescreen/regions/bookmark_menu.py
Flags: needinfo?(jlorenzo)
See Also: → 1217404
Gaia UI tests are becoming obsolete, so marking WONTFIX.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.