1222902 - Create log system for the AudioChannel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: AudioChannel, defect)

Description

[Alastor Wu [:alwu]]

Create log system for AudioChannel, so that we can debug problem more easily.

Comment 1

[Alastor Wu [:alwu]]

Attachment: MozReview Request: Bug 1222902 - Create log system for the AudioChannel. r=baku.

Bug 1222902 - Create log system for the AudioChannel

Comment 2

[Alastor Wu [:alwu]]

Hi, Baku,
As the AudioChannel doesn't have the log system, other people can't provide me useful logs to figure out the problem.
Therefore, I will want to add some log for it.

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8684796 [details]
MozReview Request: Bug 1222902 - Create log system for the AudioChannel. r=baku.

https://reviewboard.mozilla.org/r/24641/#review22191

::: dom/audiochannel/AudioChannelAgent.cpp:137
(Diff revision 1)
> +          this, mAudioChannelType, mWindow.get(), hasCallback));

put this inline: (!!mCallback || !!mWeakCallback)

::: dom/audiochannel/AudioChannelAgent.cpp:169
(Diff revision 1)
> +          this, *aMuted));

print also the volume.

::: dom/audiochannel/AudioChannelAgent.cpp:217
(Diff revision 1)
> +         ("AudioChannelAgent, WindowVolumeChanged, this = %p, mute = %d\n",

volume here too.

::: dom/audiochannel/AudioChannelService.cpp:791
(Diff revision 1)
> +  MOZ_LOG(GetAudioChannelLog(), LogLevel::Debug,

Add the same for SetAudioChannelVolume.

Comment 4

[Alastor Wu [:alwu]]

Comment on attachment 8684796 [details]
MozReview Request: Bug 1222902 - Create log system for the AudioChannel. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24641/diff/1-2/

Comment 5

[Alastor Wu [:alwu]]

Try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0dc5e35a86fd

Comment 6

[Alastor Wu [:alwu]]

Comment on attachment 8684796 [details]
MozReview Request: Bug 1222902 - Create log system for the AudioChannel. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24641/diff/2-3/

Comment 7

[Alastor Wu [:alwu]]

Rebase the patch.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/9b2c15970aa0

Comment 9

[Carsten Book [:Tomcat]]

backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=3314715&repo=b2g-inbound

Comment 10

[Alastor Wu [:alwu]]

New try-server result for win8 build.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f4c2fd810f4

Comment 11

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/b2g-inbound/rev/eeb80d0df72f

Comment 12

[Alastor Wu [:alwu]]

Comment on attachment 8684796 [details]
MozReview Request: Bug 1222902 - Create log system for the AudioChannel. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24641/diff/3-4/

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/7cb3a5f4c42a

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7cb3a5f4c42a