1222935 - Support REQUEST_SEND_USSD command

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Comment 1

[pelloux]

The scope of this bug is only to get the promise returned from telephony.dial() being resolved.

Implementing session support or emulating ussd network is not needed (yet).

Comment 2

[pelloux]

Attachment: reference-ril patch

Comment 3

[pelloux]

Attachment: update gecko test

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8688953 [details] [diff] [review]
update gecko test

Review of attachment 8688953 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you so much!

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8688953 [details] [diff] [review]
update gecko test

Review of attachment 8688953 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you so much! r=me with comment addressed.

b.t.w. as the emulator patch is going to land on emulator-kk only, we'd make sure this test is running on only emulator-kk. Please add one line right below [1],
i.e. 
[test_mmi_ussd.js]
skip-if = android_version < '19'


[1] https://dxr.mozilla.org/mozilla-central/source/dom/telephony/test/marionette/manifest.ini#50

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8688952 [details] [review]
reference-ril patch

Ultimately we will want to send AT command to modem and then wait for a response from modem for more plausible ussd session emulation. However, let's simply target the scope of comment 1 here as the first step. Since we will always return success for now, it's totally okay to simply return in reference-ril layer IMO. Thanks!

b.t.w. before asking for "checkin-needed" please attach a try result to let Sheriff knows your patch is ready and causing no other issues. I could help you to push your patches to try server this time, but you will still want a Mozilla hg account [1] for being able to use try service afterwards.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #6)
> Comment on attachment 8688952 [details] [review]
> reference-ril patch
> 
> Ultimately we will want to send AT command to modem and then wait for a
> response from modem for more plausible ussd session emulation. However,
> let's simply target the scope of comment 1 here as the first step. Since we
> will always return success for now, it's totally okay to simply return in
> reference-ril layer IMO. Thanks!
> 
> b.t.w. before asking for "checkin-needed" please attach a try result to let
> Sheriff knows your patch is ready and causing no other issues. I could help
> you to push your patches to try server this time, but you will still want a
> Mozilla hg account [1] for being able to use try service afterwards.

[1] try server instructions: https://wiki.mozilla.org/ReleaseEngineering/TryServer

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #6)
> Comment on attachment 8688952 [details] [review]
> reference-ril patch
> 
> Ultimately we will want to send AT command to modem and then wait for a
> response from modem for more plausible ussd session emulation. However,
> let's simply target the scope of comment 1 here as the first step. Since we
> will always return success for now, it's totally okay to simply return in
> reference-ril layer IMO. Thanks!
> 
> b.t.w. before asking for "checkin-needed" please attach a try result to let
> Sheriff knows your patch is ready and causing no other issues. I could help
> you to push your patches to try server this time, but you will still want a
> Mozilla hg account [1] for being able to use try service afterwards.

I left some comments on github, please take a look.

I realized that the try failures [1] result from your out-dated platform_hardware_ril branch. You will need to rebase your branch on the latest upstream.

[1] https://treeherder.allizom.org/#/jobs?repo=try&revision=0cc9bf5961ad

Comment 9

[pelloux]

Attachment: update gecko test v2

Comment 10

[pelloux]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #8)
> I realized that the try failures [1] result from your out-dated
> platform_hardware_ril branch. You will need to rebase your branch on the
> latest upstream.

What branch is 'the latest upstream'? master? b2g-kitkat?

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to pierre-eric from comment #10)
> (In reply to Hsin-Yi Tsai [:hsinyi] from comment #8)
> > I realized that the try failures [1] result from your out-dated
> > platform_hardware_ril branch. You will need to rebase your branch on the
> > latest upstream.
> 
> What branch is 'the latest upstream'? master? b2g-kitkat?

b2g-kitkat

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #11)
> (In reply to pierre-eric from comment #10)
> > (In reply to Hsin-Yi Tsai [:hsinyi] from comment #8)
> > > I realized that the try failures [1] result from your out-dated
> > > platform_hardware_ril branch. You will need to rebase your branch on the
> > > latest upstream.
> > 
> > What branch is 'the latest upstream'? master? b2g-kitkat?
> 
> b2g-kitkat

More explanations:
b2g-kitkat is the right branch, and your Phoxygen/platform_hardware_ril/commits/bug_1222935 branch is based on b2g/b2g-kitkat correctly. However, if you carefully look at the commits of your branch bug_1222935 and https://github.com/mozilla-b2g/platform_hardware_ril/commits/b2g-kitkat (the right and latest upstream), you will see that your bug_1222935 is missing one commit from bevis-tseng that I believe is the root cause of the try failure. So, make sure your bug_1222935 contains all the commits on the right upstream.

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

A new try commit based on updated branch: https://treeherder.allizom.org/#/jobs?repo=try&revision=ecc5d2ff2b65

Comment 14

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #13)
> A new try commit based on updated branch:
> https://treeherder.allizom.org/#/jobs?repo=try&revision=ecc5d2ff2b65

Mnw is green, ready to land!

Comment 15

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/2b1a10c958156968bc4842471ffa9c919ee80e92
Bug 1222935 - Support REQUEST_SEND_USSD command. r=hsinyi

Comment 16

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Edgar,
could you help merge the hardware/ril branch? Thank you!

Comment 17

[Edgar Chen [:edgar]]

b2g-kitkat:
https://github.com/mozilla-b2g/platform_hardware_ril/commit/d3ab8090c5c2ac77429575131c4718d96bfb93cc

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b1a10c95815