Closed Bug 1223386 Opened 9 years ago Closed 9 years ago

Share menu is misplaced after changing orientation on iPads

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
fxios 1.3+ ---

People

(Reporter: csuciu, Assigned: philippe.bernery, Mentored)

Details

(Keywords: polish)

Attachments

(2 files)

Screen Shot 2015-11-10 at 16.38.09.png
2.64 MB, image/png
Details
Pull request
48 bytes, text/x-github-pull-request
st3fan
: review+
sleroux
: review+
sleroux
: feedback+
Details | Review 
Build: Beta 1202
iPad Air 2 (9.1)

Steps:
1. Tap on share button while the device is in portrait mode
2. Switch to landscape

Result: The share menu is misplaced after switching orientation
Mentor: sleroux
tracking-fxios: ? → +
Keywords: polish
Whiteboard: [good first bug][lang=swift]
Attached file Pull request — 

        Attachment #8686546 -
        Flags: review?(sarentz)

    
    

    
  
Comment on attachment 8686546 [details] [review]
Pull request

I think this looks good but I think it will be good if :sleroux can take a peek too.

        Attachment #8686546 -
        Flags: review?(sleroux)

        Attachment #8686546 -
        Flags: review?(sarentz)

        Attachment #8686546 -
        Flags: review+

    
    

    
  
Comment on attachment 8686546 [details] [review]
Pull request

Good approach - just left some comments about the deprecated API and some minor clean up we can do.

        Attachment #8686546 -
        Flags: feedback+
Assignee: nobody → philippe.bernery
Status: NEW → ASSIGNED

    
    

    
  
I updated my PR following your recommendations.

    
    

    
  
One last night and I think we're good to go :)
Rank: 3

    
    

    
  
PR updated :)

    
    

    
  
Comment on attachment 8686546 [details] [review]
Pull request

Awesome! Thanks for fixing it up. I'll go ahead and land it.

        Attachment #8686546 -
        Flags: review?(sleroux) → review+

    
    

    
  
Landed

f09aa73786006634c7179ee5ef48331b37da87a1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
Whiteboard: [good first bug][lang=swift] → [needsuplift]
Flags: needinfo?(catalin.suciu)
Keywords: verifyme
Whiteboard: [needsuplift]

    
    

    
  
Verifying as fixed on TF build 1303
Flags: needinfo?(catalin.suciu)
Keywords: verifyme

    
  
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: