Closed
Bug 1223400
Opened 9 years ago
Closed 8 years ago
Replace SwiftKeychainWrapper source with Carthage import
Categories
(Firefox for iOS :: Build & Test, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 2.0+ | --- |
People
(Reporter: sleroux, Assigned: fluffyemily)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
There's an open issue to support Carthage and it looks like it's working but might need to be updated to Swift 2.1 to avoid warnings: https://github.com/jrendel/SwiftKeychainWrapper/issues/14 Since 2.0 -> 2.1 isn't too bad, we can even submit a patch to get it in a non-warning state. Looks like it's working though.
There is an open pull request that removes the warnings (see [1]). However, these are only warnings and on top they only affect the unit tests so there should be nothing blocking the build. [1] https://github.com/jrendel/SwiftKeychainWrapper/pull/25
|
Reporter | |
Updated•9 years ago
|
tracking-fxios:
? → ---
|
||
Updated•9 years ago
|
tracking-fxios:
--- → 2.0+
Hardware: Other → All
|
Assignee | |
Comment 3•8 years ago
|
||
Part 1 of using carthage correctly - move GDCWebserver in ThirdParty to reference version fetched by carthage
Attachment #8704142 -
Flags: review?(sleroux)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → etoop
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•8 years ago
|
||
:sleroux - pinned GCDWebServer and SwiftKeychainWrapper to a particular version
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8704142 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•