1223609 - Update MotionEventHelper.java to work with C++APZ

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Randall Barker [:rbarker]]

The functions dragAsync and flingAsync do not work with C++APZ. Function dragAsync needs to account for the touch start tolerance when calculating drag distance. Function flingAsync needs to ensure that the touch up event time is later than the last touch move event time.

Comment 1

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1223609-Update-MotionEventHelper.java-to-work-with-C-APZ-15111016-77ebd50.patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Is there a reason you didn't want to just drop the touch_start_tolerance to 0 instead, and then do a 1-pixel drag? That's what we do at [1] for example. I feel like that's a more robust solution in general.

[1] http://mxr.mozilla.org/mozilla-central/source/gfx/layers/apz/test/mochitest/test_basic_pan.html?rev=97f3299a0c38&force=1#43

Comment 3

[Randall Barker [:rbarker]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> Is there a reason you didn't want to just drop the touch_start_tolerance to
> 0 instead, and then do a 1-pixel drag? That's what we do at [1] for example.
> I feel like that's a more robust solution in general.
> 
> [1]
> http://mxr.mozilla.org/mozilla-central/source/gfx/layers/apz/test/mochitest/
> test_basic_pan.html?rev=97f3299a0c38&force=1#43

I tried that first and it didn't work. Because the down event and move event are at the same location, there is no change in position and the axis lock in C++APZ fails and always locks to the x axis. I have a patch to fix that issue so that APZC doesn't transition from Touching to Panning until the movement is non zero. Unfortunately, this cause the drag to loose about 5 pixels since basically the first move event is ignored. Additionally, this makes the test closer to real world conditions which might be worth loss of robustness.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c30ece891309

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c30ece891309