Closed Bug 1223677 Opened 9 years ago Closed 9 years ago

handlePresentation will get stuck when url protocol is not APP

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.6 S2 - 12/4

People

(Reporter: chunmin, Assigned: chunmin)

Details

Attachments

(1 file, 3 obsolete files)

[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
chunmin
: review+
Details | Review 
This line:
https://github.com/mozilla-b2g/gaia/blob/2f1bf00b579f8183eb30d4459b2eca27503ac015/tv_apps/smart-system/js/app_window_factory.js#L127

will get error when |protocol != 'APP:'| because |config.manifest| is null
Assignee: nobody → cchang
Comment on attachment 8685877 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

Hi, Rex,
I was wondering if you could review this small patch for me.
Attachment #8685877 - Flags: review?(rexboy)
Comment on attachment 8685877 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

Looks good to me, but I'm not sure if the use case with no manifestURL works. For fling webpage we sends request through notification-manager right now.
Attachment #8685877 - Flags: review?(rexboy) → review+
Comment on attachment 8689454 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

(In reply to KM Lee [:rexboy] from comment #3)
Hi, Rex,
Sorry to bother you again. I would like to change a little bit from my previous patch. 

If we only allow those apps that have presentation permission to use presentation api, I think it's better to ignore all requests with non-app url protocol in handlePresentation.
Attachment #8689454 - Flags: review?(rexboy)
Comment on attachment 8689454 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

r+ with 1 changes required.
Please send deny message back to Gecko before return.
Attachment #8689454 - Flags: review?(rexboy) → review+
Attachment #8685877 - Attachment is obsolete: true
Attachment #8689454 - Attachment is obsolete: true
Comment on attachment 8690642 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

Carry r+
Attachment #8690642 - Flags: review+
Attachment #8690642 - Attachment is obsolete: true
Comment on attachment 8692906 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

rename summary and carry r+
Attachment #8692906 - Flags: review+
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/85834ae546bc408adba6d15629eb147ac91f8999
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S2 - 12/4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: